Summary: | Make NetworkCache::traverse faster | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2015-06-26 11:17:01 PDT
Created attachment 255655 [details]
patch
Attachment 255655 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:51: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:52: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:91: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 4 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 255655 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=255655&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:107 > +void IOChannel::write(size_t offset, const Data& data, WorkQueue* queue, const std::function<void (int error)>& completionHandler) I don't think this should be a const& since that's an extra copy. > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:704 > + std::unique_ptr<TraverseOperation> traverseOperationPtr(new TraverseOperation { flags, WTF::move(traverseHandler) }); auto + std::make_unique? Antti, please, consider fixing GTK+ build before landing. You just need to do the same changes in NetworkCacheIOChannelSoup.cpp and include <condition_variable> in NetworkCacheStorage.cpp Created attachment 255698 [details]
patch
Attachment 255698 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|