Bug 146348 – Network process hangs fetching disk cache entries

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Antti Koivisto]

Main thread hang:

1000  WTF::RunLoop::performWork(void*) + 34 (JavaScriptCore + 6417650) [0x7fff99a4fcf2]
    1000  WTF::RunLoop::performWork() + 696 (JavaScriptCore + 6416184) [0x7fff99a4f738]
      1000  std::__1::__function::__func<WebKit::fetchDiskCacheEntries(WebCore::SessionID, std::__1::function<void (WTF::Vector<WebKit::WebsiteData::Entry, 0ul, WTF::CrashOnOverflow, 16ul>)>)::$_6::operator()(WebKit::NetworkCache::Entry const*) const::'lambda'(), std::__1::allocator<WebKit::fetchDiskCacheEntries(WebCore::SessionID, std::__1::function<void (WTF::Vector<WebKit::WebsiteData::Entry, 0ul, WTF::CrashOnOverflow, 16ul>)>)::$_6::operator()(WebKit::NetworkCache::Entry const*) const::'lambda'()>, void ()>::destroy_deallocate() + 43 (WebKit + 1040353) [0x7fff8dc41fe1]
          1000  std::__1::__function::__func<WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, unsigned long long, unsigned long long)::$_2, std::__1::allocator<WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, unsigned long long, unsigned long long)::$_2>, void (WTF::Vector<WebKit::WebsiteData::Entry, 0ul, WTF::CrashOnOverflow, 16ul>)>::destroy_deallocate() + 18 (WebKit + 1043380) [0x7fff8dc42bb4]
          1000  WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, unsigned long long, unsigned long long)::$_2::~$_2() + 839 (WebKit + 1036459) [0x7fff8dc410ab]
            1000  WTF::RunLoop::dispatch(std::__1::function<void ()>) + 28 (JavaScriptCore + 6416492) [0x7fff99a4f86c]
              1000  __psynch_mutexwait + 10 (libsystem_kernel.dylib + 94070) [0x7fff9a16df76]
               *1000  psynch_mtxcontinue + 0 (pthread + 25501) [0xffffff7f810ee39d]

[Antti Koivisto]

Created attachment 255643 [details]
patch

[WebKit Commit Bot]

Attachment 255643 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

<rdar://problem/21528072>

[Anders Carlsson]

Comment on attachment 255643 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255643&action=review

> Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp:40
> +    struct Foo {

Please call this something else, like DispatchFromDestructorTester.

[Antti Koivisto]

https://trac.webkit.org/r186006