Bug 146330

Summary: [WIN] Enable WEB_TIMING API
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, ddkilzer, ossy, peavo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2015-06-25 16:15:28 PDT
We fail certain HTML5 tests because we do not provide any support for 'window.performance'. Expose this on Windows so we do not arbitrarily fail. Future work may be needed to get proper accuracy for some performance counters, but these can be tracked as specific bugs.
Attachments
Patch (4.66 KB, patch)
2015-06-25 16:23 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-06-25 16:22:31 PDT
<rdar://problem/21530765>
Brent Fulgham
Comment 2 2015-06-25 16:23:19 PDT
Created attachment 255591 [details] Patch
Brent Fulgham
Comment 3 2015-06-25 16:48:16 PDT
Committed r185971: <http://trac.webkit.org/changeset/185971>
Csaba Osztrogonác
Comment 4 2015-06-25 23:52:17 PDT
(In reply to comment #3) > Committed r185971: <http://trac.webkit.org/changeset/185971> It broke the WinCairo build: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/46799/steps/compile-webkit/logs/stdio Why did you enable it for curl if it doesn't build at all?
David Kilzer (:ddkilzer)
Comment 5 2015-06-26 00:12:26 PDT
(In reply to comment #3) > Committed r185971: <http://trac.webkit.org/changeset/185971> Follow-up fix for layout test failure: r185990 <http://trac.webkit.org/changeset/185990> Failure in js/dom/global-constructors-attributes.html: <https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r185983%20(52634)/results.html>
Csaba Osztrogonác
Comment 6 2015-06-26 04:40:04 PDT
I disabled it on WinCairo again to fix the build - http://trac.webkit.org/changeset/185993 If you would like to enable it again, please fix the build first.
Note You need to log in before you can comment on or make changes to this bug.