Bug 146329

Summary: [iOS WK2] Swiping back just after scrolling can cause some tiles to disappear
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, esprehn+autocc, glenn, gustavo, kondapallykalyan, mcatanzaro, mrobinson, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch simon.fraser: review+

Simon Fraser (smfr)
Reported 2015-06-25 16:02:53 PDT
[iOS WK2] Swiping back just after scrolling can cause some tiles to disappear
Attachments
Patch (15.06 KB, patch)
2015-06-25 16:28 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (15.28 KB, patch)
2015-06-25 17:03 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (16.61 KB, patch)
2015-06-25 17:16 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (17.60 KB, patch)
2015-06-25 17:24 PDT, Simon Fraser (smfr) 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2015-06-25 16:28:37 PDT
Created attachment 255592 [details] Patch
Simon Fraser (smfr)
Comment 2 2015-06-25 16:29:19 PDT
rdar://problem/21233010
Tim Horton
Comment 3 2015-06-25 16:41:18 PDT
Comment on attachment 255592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255592&action=review > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:706 > +void PageClientImpl::beginNavigationGestureInteraction() Slightly sad that navigationGestureDidBegin/didEnd aren't sufficient, but they're called on the other view I guess? All they do is notify the client, so it seems like you could piggyback on those (and send them to both WebPageProxies, if they're different). Either way is fine with me.
Simon Fraser (smfr)
Comment 4 2015-06-25 17:03:57 PDT
Created attachment 255599 [details] Patch
Simon Fraser (smfr)
Comment 5 2015-06-25 17:16:01 PDT
Created attachment 255601 [details] Patch
WebKit Commit Bot
Comment 6 2015-06-25 17:17:41 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Simon Fraser (smfr)
Comment 7 2015-06-25 17:24:33 PDT
Created attachment 255602 [details] Patch
Simon Fraser (smfr)
Comment 8 2015-06-25 17:31:07 PDT
Comment on attachment 255602 [details] Patch Tim reviewed this.
Simon Fraser (smfr)
Comment 9 2015-06-25 17:31:16 PDT
https://trac.webkit.org/r185972
Note You need to log in before you can comment on or make changes to this bug.