Bug 146328

Summary: Inline media controls disappear when returning a video to inline
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Dean Jackson 2015-06-25 15:50:27 PDT 
Inline media controls disappear when returning a video to inline
Comment 1 Dean Jackson 2015-06-25 15:57:17 PDT 
        <rdar://problem/21142862>
Comment 2 Dean Jackson 2015-06-25 15:57:43 PDT 
Created attachment 255585 [details]
Patch
Comment 3 Tim Horton 2015-06-25 16:07:05 PDT 
Comment on attachment 255585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review

> Source/WebCore/ChangeLog:33
> +        naming doesn't make much sense :(

this is sad, indeed.
Comment 4 Dean Jackson 2015-06-25 16:15:36 PDT 
Committed r185969: <http://trac.webkit.org/changeset/185969>
Comment 5 Eric Carlson 2015-06-25 18:01:19 PDT 
Comment on attachment 255585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review

r=me too

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:350
> +        if (this.controlsAreHidden() || !this.controls.panel.classList.contains(this.ClassNames.show)) {

Now might not be the time to do this, but we should consider putting this logic into controlsAreHidden.