Bug 146328

Summary: Inline media controls disappear when returning a video to inline
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Dean Jackson
Reported 2015-06-25 15:50:27 PDT
Inline media controls disappear when returning a video to inline
Attachments
Patch (4.54 KB, patch)
2015-06-25 15:57 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2015-06-25 15:57:17 PDT
<rdar://problem/21142862>
Dean Jackson
Comment 2 2015-06-25 15:57:43 PDT
Created attachment 255585 [details] Patch
Tim Horton
Comment 3 2015-06-25 16:07:05 PDT
Comment on attachment 255585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review > Source/WebCore/ChangeLog:33 > + naming doesn't make much sense :( this is sad, indeed.
Dean Jackson
Comment 4 2015-06-25 16:15:36 PDT
Committed r185969: <http://trac.webkit.org/changeset/185969>
Eric Carlson
Comment 5 2015-06-25 18:01:19 PDT
Comment on attachment 255585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255585&action=review r=me too > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:350 > + if (this.controlsAreHidden() || !this.controls.panel.classList.contains(this.ClassNames.show)) { Now might not be the time to do this, but we should consider putting this logic into controlsAreHidden.
Note You need to log in before you can comment on or make changes to this bug.