| Summary: | Debug configuration doesn't work with qmake. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Donald Luo <donaldluo> | ||||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | son.two, zecke | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 523.x (Safari 3) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Donald Luo
2007-07-16 06:43:51 PDT
Created attachment 15531 [details]
Patch to webkitdirs.pm
Created attachment 16013 [details]
enhanced patch
as far as I know qmake could be configured to use debug configuration by default,
so it looks reasonable to enhance the patch to explicitly drop unneedded mode.
Created attachment 16014 [details]
the enhanced patch with corrected indentation
I'm no perl expert but it looks okay. Comment on attachment 16014 [details]
the enhanced patch with corrected indentation
r=me. The amount of duplication between buildQMakeProject and buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at some point.
(In reply to comment #5) > (From update of attachment 16014 [details] [edit]) > r=me. The amount of duplication between buildQMakeProject and > buildQMakeGdkProject is depressing. It'd be great if it could be cleaned up at > some point. > I will see what I can do to reduce duplication :) Created attachment 16017 [details]
change log for the patch
|