Summary: | [SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the the resources depending on the date | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, koivisto, svillar | ||||
Priority: | P2 | Keywords: | Soup | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-06-25 08:20:23 PDT
Created attachment 255555 [details]
Patch
Attachment 255555 [details] did not pass style-queue:
ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:156: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 255555 [details]
Patch
Don't we have layout tests for this?
(In reply to comment #3) > Comment on attachment 255555 [details] > Patch > > Don't we have layout tests for this? I don't think so, this is more for an API test I think, and there will be one for GTK+ when we expose clear_cache in WebKitWebsiteDataManager. Writing that unit tests is how I noticed this issue, indeed. Committed r186022: <http://trac.webkit.org/changeset/186022> |