Bug 146316 – [SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the the resources depending on the date

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

And make sure the completion handler is called, as well. This functionality is already implemented in Storage::clear(), so we just need to pass the time point and completion handler to Cache::clear().

[Carlos Garcia Campos]

Created attachment 255555 [details]
Patch

[WebKit Commit Bot]

Attachment 255555 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:156:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sergio Villar Senin]

Comment on attachment 255555 [details]
Patch

Don't we have layout tests for this?

[Carlos Garcia Campos]

(In reply to comment #3)
> Comment on attachment 255555 [details]
> Patch
> 
> Don't we have layout tests for this?

I don't think so, this is more for an API test I think, and there will be one for GTK+ when we expose clear_cache in WebKitWebsiteDataManager. Writing that unit tests is how I noticed this issue, indeed.

[Carlos Garcia Campos]

Committed r186022: <http://trac.webkit.org/changeset/186022>