Bug 146296

Summary:

WebContent process is unreponsive/idle when WKWebView is inside a view service.

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Anders Carlsson 2015-06-24 16:23:42 PDT

WebContent process is unreponsive/idle when WKWebView is inside a view service.

Comment 1 Anders Carlsson 2015-06-24 16:33:58 PDT

Created attachment 255526 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-24 16:35:21 PDT

Attachment 255526 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:76:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:97:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Tim Horton 2015-06-24 16:53:31 PDT

Comment on attachment 255526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255526&action=review

> Source/WebKit2/UIProcess/ApplicationStateTracker.mm:51
> +    if ([[NSBundle mainBundle].bundleIdentifier isEqualToString:@"com.apple.SafariViewService"])

Please try to find a better less layering-violating way to do this.

Comment 4 Anders Carlsson 2015-06-24 16:57:11 PDT

Committed r185936: <http://trac.webkit.org/changeset/185936>