Bug 146286

Summary:

Null dereference in DocumentLoader::areAllLoadersPageCacheAcceptable()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Page Loading

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, barraclough, commit-queue, ddkilzer, japhet, kling

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Chris Dumez 2015-06-24 12:48:43 PDT

Null dereference in DocumentLoader::areAllLoadersPageCacheAcceptable():
Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   WebCore                       	0x00000001959dd948 WebCore::Page::sessionID() const + 0 (Page.cpp:1677)
1   WebCore                       	0x0000000195009efc WebCore::DocumentLoader::stopLoading() + 452 (DocumentLoader.cpp:106)
2   WebCore                       	0x000000019501992c WebCore::DocumentLoader::detachFromFrame() + 60 (DocumentLoader.cpp:924)
3   WebCore                       	0x00000001950a0248 WebCore::FrameLoader::detachViewsAndDocumentLoader() + 84 (FrameLoader.cpp:1688)
4   WebCore                       	0x0000000195099798 WebCore::CachedFrame::destroy() + 56 (CachedFrame.cpp:261)
5   WebCore                       	0x00000001950997c8 WebCore::CachedFrame::destroy() + 104 (CachedFrame.cpp:265)
6   WebCore                       	0x0000000195099730 WebCore::CachedPage::~CachedPage() + 24 (CachedPage.cpp:68)

Comment 1 Chris Dumez 2015-06-24 12:48:56 PDT

<rdar://problem/21523788>

Comment 2 Chris Dumez 2015-06-24 12:53:58 PDT

Created attachment 255505 [details]
Patch

Comment 3 Sam Weinig 2015-06-24 14:42:20 PDT

Comment on attachment 255505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255505&action=review

> Source/WebCore/ChangeLog:10
> +        Add null check for the Page in areAllLoadersPageCacheAcceptable()
> +        to fix this top crasher until I can how this can happen.

"until I can how this can happen." doesn't quite make sense.

Comment 4 Chris Dumez 2015-06-24 14:44:42 PDT

Committed r185927: <http://trac.webkit.org/changeset/185927>