Bug 146281

Summary: outline does not play nicely with line-height
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, jonlee, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Reduction none

Description Myles C. Maxfield 2015-06-24 09:32:22 PDT
Created attachment 255485 [details]
Reduction

See attached reduction.
Comment 1 Jon Lee 2015-06-24 10:25:19 PDT
Both Safari and Chrome try to encompass the shape of the entire <span>, while Firefox outlines each line individually.
Comment 2 Myles C. Maxfield 2015-06-24 11:38:24 PDT
It doesn't really seem spec'ed which one is right. It seems to me that we should keep our current behavior but just connect the vertical gaps (where we have triangles) in our red lines.
Comment 3 Ahmad Saleem 2022-07-26 04:26:45 PDT
I am still able to reproduce this bug in Safari 15.6 on macOS 12.5 using attached reduction. All other browsers (Chrome Canary 106 and Firefox Nightly 104) match with each other, while Safari differ in "outline" case and show weird outline, which is partial cut off from various places and some missing altogether. Just wanted to share updated testing results. Thanks!
Comment 4 Radar WebKit Bug Importer 2022-07-26 19:48:45 PDT
<rdar://problem/97642002>
Comment 5 Ahmad Saleem 2023-02-18 15:45:45 PST
It seems to be fixed in STP163 & WebKit ToT (260520@main), Outline now follows and matches other browsers. Broken in Safari 16.3 still though.

Marking this as "RESOLVED CONFIGURATION CHANGED". Another old bug down. Thanks!
Comment 6 zalan 2023-02-18 16:10:38 PST
This got progressed around 255314@main (re-worked outline painting to support border-radius).