Bug 146264

Summary:

Refactoring benchmark runner script to follow pep8 code style.

Product:

WebKit

Reporter:

dewei_zhu

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dewei_zhu, glenn, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description dewei_zhu 2015-06-23 17:17:54 PDT

Refactoring benchmark runner script to follow pep8 code style.

Comment 1 dewei_zhu 2015-06-23 18:14:30 PDT

Created attachment 255462 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-23 18:17:22 PDT

Attachment 255462 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:94:  [SimpleHTTPServerDriver.kill_server] Instance of 'Popen' has no 'terminate' member  [pylint/E1101] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 WebKit Commit Bot 2015-06-23 19:14:13 PDT

Comment on attachment 255462 [details]
Patch

Clearing flags on attachment: 255462

Committed r185898: <http://trac.webkit.org/changeset/185898>

Comment 4 WebKit Commit Bot 2015-06-23 19:14:18 PDT

All reviewed patches have been landed.  Closing bug.