Bug 146262 – test262: class and function names should be inferred in assignment

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Ryosuke Niwa]

It looks like ES6 spec requires the inferred name.
Since we already compute that for Inspector, we should just return it.
We're missing 14 out of 17 points on https://kangax.github.io/compat-table/es6/ :(

[Joseph Pecoraro]

I've started work on this. Just a basic implementation gets us 650+ test262 tests.

[Joseph Pecoraro]

Created attachment 290191 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 290191 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=290191&action=review

> JSTests/stress/inferred-names.js:34
> +// assert( ({["func"]: ()=>{}}).func.name === "func" );

Not putting r? yet because of this case (arrow function in computed property assignment) that didn't seem to infer name but normal function did. Funny, I didn't see this covered in test262.

[Joseph Pecoraro]

Created attachment 290192 [details]
[PATCH] Start of Fix

[Joseph Pecoraro]

Created attachment 290193 [details]
[PATCH] Proposed Fix

Never got to the bottom of that issue, but filed a separate bug on it. It would seem to be a runtime thing, not a parse time.

[Joseph Pecoraro]

Created attachment 290195 [details]
[PATCH] Proposed Fix

Doing the same for class gets us another ~160

[Build Bot]

Comment on attachment 290195 [details]
[PATCH] Proposed Fix

Attachment 290195 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2167737

New failing tests:
fast/images/pdf-as-image-with-annotations.html

[Build Bot]

Created attachment 290199 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Comment on attachment 290195 [details]
[PATCH] Proposed Fix

Test failure is unrelated.

[Saam Barati]

Comment on attachment 290195 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=290195&action=review

r=me

> Source/JavaScriptCore/parser/ASTBuilder.h:346
> +        if (rhs->isBaseFuncExprNode()) {

Nice, this removes a virtual call

[WebKit Commit Bot]

Comment on attachment 290195 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 290195

Committed r206599: <http://trac.webkit.org/changeset/206599>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.