Bug 146234 – [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

This is because we don't provide any quota, and 0 is used by default, so there's never enough quota and openDatabase fails.

[Carlos Garcia Campos]

Created attachment 255405 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Attachment 255405 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Created attachment 255997 [details]
Patch

Rebased to current trunk and also enables the WebSQL directory unit test that is currently disabled because of this bug.

[WebKit Commit Bot]

Attachment 255997 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

EWS failure is not because of this patch, but the internal jhbuild doing too much stuff for every patch and sometimes failing to do so.

[Sergio Villar Senin]

Comment on attachment 255997 [details]
Patch

So aren't we running WebSQL layout tests?

[Carlos Garcia Campos]

(In reply to comment #7)
> Comment on attachment 255997 [details]
> Patch
> 
> So aren't we running WebSQL layout tests?

WTR implements this callback, returning also 5MB.

[Sergio Villar Senin]

(In reply to comment #8)
> (In reply to comment #7)
> > Comment on attachment 255997 [details]
> > Patch
> > 
> > So aren't we running WebSQL layout tests?
> 
> WTR implements this callback, returning also 5MB.

My point was, we either run them and all of them were failing, or we are skipping them and you aren't unskipping them.

[Carlos Garcia Campos]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Comment on attachment 255997 [details]
> > > Patch
> > > 
> > > So aren't we running WebSQL layout tests?
> > 
> > WTR implements this callback, returning also 5MB.
> 
> My point was, we either run them and all of them were failing, or we are
> skipping them and you aren't unskipping them.

We run them and they don't fail because WTR implements that callback in its UI client.

[Carlos Garcia Campos]

Committed r186225: <http://trac.webkit.org/changeset/186225>