Bug 146234

Summary:

[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, commit-queue, gustavo, mcatanzaro, mrobinson, svillar

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	svillar: review+

Description Carlos Garcia Campos 2015-06-23 04:13:21 PDT

This is because we don't provide any quota, and 0 is used by default, so there's never enough quota and openDatabase fails.

Comment 1 Carlos Garcia Campos 2015-06-23 04:18:10 PDT

Created attachment 255405 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-23 04:19:17 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 WebKit Commit Bot 2015-06-23 04:19:29 PDT

Attachment 255405 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Carlos Garcia Campos 2015-07-02 00:17:43 PDT

Created attachment 255997 [details]
Patch

Rebased to current trunk and also enables the WebSQL directory unit test that is currently disabled because of this bug.

Comment 5 WebKit Commit Bot 2015-07-02 00:20:33 PDT

Attachment 255997 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Carlos Garcia Campos 2015-07-02 00:25:50 PDT

EWS failure is not because of this patch, but the internal jhbuild doing too much stuff for every patch and sometimes failing to do so.

Comment 7 Sergio Villar Senin 2015-07-02 03:10:03 PDT

Comment on attachment 255997 [details]
Patch

So aren't we running WebSQL layout tests?

Comment 8 Carlos Garcia Campos 2015-07-02 03:27:47 PDT

(In reply to comment #7)
> Comment on attachment 255997 [details]
> Patch
> 
> So aren't we running WebSQL layout tests?

WTR implements this callback, returning also 5MB.

Comment 9 Sergio Villar Senin 2015-07-02 03:58:46 PDT

(In reply to comment #8)
> (In reply to comment #7)
> > Comment on attachment 255997 [details]
> > Patch
> > 
> > So aren't we running WebSQL layout tests?
> 
> WTR implements this callback, returning also 5MB.

My point was, we either run them and all of them were failing, or we are skipping them and you aren't unskipping them.

Comment 10 Carlos Garcia Campos 2015-07-02 04:49:43 PDT

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Comment on attachment 255997 [details]
> > > Patch
> > > 
> > > So aren't we running WebSQL layout tests?
> > 
> > WTR implements this callback, returning also 5MB.
> 
> My point was, we either run them and all of them were failing, or we are
> skipping them and you aren't unskipping them.

We run them and they don't fail because WTR implements that callback in its UI client.

Comment 11 Carlos Garcia Campos 2015-07-02 06:01:43 PDT

Committed r186225: <http://trac.webkit.org/changeset/186225>