Bug 146231

Summary: [CSS Grid Layout] Performance optimization: avoid computing overflow alignment if not needed
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Javier Fernandez
Reported 2015-06-23 01:55:58 PDT
We we compute grid item's position, both along column and row axis, we compute overflow even if alignment value is 'start' and there is no need of applying any overflow handling, given that there is no risk of data loss. Computing overflow adds an unnecessary overhead, so we should remove it to improve performance.
Attachments
Patch (4.48 KB, patch)
2015-06-23 03:44 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2015-06-23 06:21 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-06-23 03:44:11 PDT
Created attachment 255404 [details] Patch
Sergio Villar Senin
Comment 2 2015-06-23 06:14:35 PDT
Comment on attachment 255404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255404&action=review Yay! > Source/WebCore/ChangeLog:11 > + This patch avoid, computing the overflow in all the cases, since it adds an unneeded "This patch avoids computing"
Javier Fernandez
Comment 3 2015-06-23 06:21:23 PDT
Created attachment 255408 [details] Patch
WebKit Commit Bot
Comment 4 2015-06-23 07:18:59 PDT
Comment on attachment 255408 [details] Patch Clearing flags on attachment: 255408 Committed r185874: <http://trac.webkit.org/changeset/185874>
WebKit Commit Bot
Comment 5 2015-06-23 07:19:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.