Bug 146220

Summary: [cssjit] Disable compiling scrollbar pseudoclass selectors
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Description Alex Christensen 2015-06-22 18:01:17 PDT 
Selectors like this don't work correctly in the css jit
body :not(.example_id):hover::-webkit-scrollbar-thumb:horizontal

Let's just not compile them until this is fixed.
Comment 1 Alex Christensen 2015-06-22 18:03:17 PDT 
This will be fixed in https://bugs.webkit.org/show_bug.cgi?id=146221
Comment 2 Alex Christensen 2015-06-22 18:04:37 PDT 
Created attachment 255382 [details]
Patch
Comment 3 Benjamin Poulain 2015-06-22 18:06:59 PDT 
Comment on attachment 255382 [details]
Patch

Ok
Comment 4 Alex Christensen 2015-06-22 18:10:16 PDT 
http://trac.webkit.org/changeset/185854
Comment 5 Simon Fraser (smfr) 2015-06-22 18:19:36 PDT 
Why doesn't the changelog explain why you disabled them?
Comment 6 Alex Christensen 2015-06-22 18:31:19 PDT 
I figured that information would be in bugzilla.  Maybe I should put more info in the ChangeLogs.

This patch makes it use the correct non-compiled CSS selector interpreter with scrollbar pseudo classes instead of the css jit, which behaves incorrectly with :not and scrollbar pseudo classes.  It is a slight performance hit when scrollbars are used, which is not very often.