| Summary: | Improve the source code generated by make_names.pl | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||
| Status: | REOPENED --- | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cgarcia, cmarcelo, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, ossy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 146276 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Zan Dobersek
2015-06-22 10:02:50 PDT
Created attachment 255354 [details]
Patch
Comment on attachment 255354 [details] Patch Clearing flags on attachment: 255354 Committed r185906: <http://trac.webkit.org/changeset/185906> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 146276 (In reply to comment #2) > Comment on attachment 255354 [details] > Patch > > Clearing flags on attachment: 255354 > > Committed r185906: <http://trac.webkit.org/changeset/185906> Additionally it made all layout and performance tests crash on the EFL bots: - https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/22711 - https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/5989 Created attachment 255492 [details]
Patch
Now uses std::tuple_size<>::value to get the size of the std::array objects.
(In reply to comment #6) > Created attachment 255492 [details] > Patch > > Now uses std::tuple_size<>::value to get the size of the std::array objects. Tests still crash on EFL with this patch. :-/ Comment on attachment 255492 [details]
Patch
Please don't land it before fixing the crashes on EFL.
If I can help debugging this issue, just ping me on IRC.
(In reply to comment #8) > Comment on attachment 255492 [details] > Patch > > Please don't land it before fixing the crashes on EFL. > If I can help debugging this issue, just ping me on IRC. Can you attach a backtrace of the crash that's happening on a clean build with this patch applied? (In reply to comment #9) > (In reply to comment #8) > > Comment on attachment 255492 [details] > > Patch > > > > Please don't land it before fixing the crashes on EFL. > > If I can help debugging this issue, just ping me on IRC. > > Can you attach a backtrace of the crash that's happening on a clean build > with this patch applied? Why isn't enough what the buildbot produced? https://bugs.webkit.org/show_bug.cgi?id=146208#c5 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Comment on attachment 255492 [details] > > > Patch > > > > > > Please don't land it before fixing the crashes on EFL. > > > If I can help debugging this issue, just ping me on IRC. > > > > Can you attach a backtrace of the crash that's happening on a clean build > > with this patch applied? > > Why isn't enough what the buildbot produced? > https://bugs.webkit.org/show_bug.cgi?id=146208#c5 I can't produce the issue myself on the EFL port, testing a clean build produced with GCC 4.8. (In reply to comment #11) > I can't produce the issue myself on the EFL port, testing a clean build > produced with GCC 4.8. I'll check a clean build with this patch soon. ( in 1-2 hours ) (In reply to comment #12) > (In reply to comment #11) > > I can't produce the issue myself on the EFL port, testing a clean build > > produced with GCC 4.8. > > I'll check a clean build with this patch soon. ( in 1-2 hours ) I still get the same crashes as the bot with this patch on Ubuntu 15.04 (GCC 4.9) and no crash without the patch. Gyuyoung, have you got any idea what can be the problem here? Created attachment 284445 [details]
WIP patch
Attachment 284445 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|