Bug 146193

Summary: [Mac] MiniBrowser: The context menu on PluginView is displayed in the wrong position
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit2Assignee: Sungmann Cho <sungmann.cho>
Status: NEW    
Severity: Normal CC: andersca, beidson, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Screenshot of the issue
none
Patch beidson: review-, beidson: commit-queue-

Sungmann Cho
Reported 2015-06-21 07:54:57 PDT
In order to calculate the exact position of the context menu on netscape plugins, the plugin instances need to know the size of the window frame in screen coordinates. This size is passed to NetscapePlugin::windowAndViewFramesChanged() from WebPageProxy::windowAndViewFramesChanged() and WebPageProxy::windowAndViewFramesChanged() gets the size from API::UIClient::windowFrame(), but the result is always 0 because there is no overridden implementation to return the actual size of the window frame.
Attachments
Screenshot of the issue (13.76 MB, image/png)
2015-06-21 08:06 PDT, Sungmann Cho 		no flags
Details
Patch (3.37 KB, patch)
2015-06-21 08:09 PDT, Sungmann Cho 		beidson: review-
beidson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-06-21 08:06:21 PDT
Created attachment 255324 [details] Screenshot of the issue
Sungmann Cho
Comment 2 2015-06-21 08:09:17 PDT
Created attachment 255325 [details] Patch
Darin Adler
Comment 3 2015-06-23 12:08:56 PDT
Any good way to make a regression test? Anders, does this seem like the right fix?
Sungmann Cho
Comment 4 2015-07-02 06:31:58 PDT
Is there a regression test suite for testing MiniBrowser itself? And I wanna know the patch is right.
Darin Adler
Comment 5 2015-07-02 09:38:21 PDT
(In reply to comment #4) > Is there a regression test suite for testing MiniBrowser itself? No. But despite the bug title, this is not a bug in MiniBrowser.
Anders Carlsson
Comment 6 2015-07-02 10:49:45 PDT
Need to double check what we do inside Safari and why there's even a UIDelegate client callback for this.
Brady Eidson
Comment 7 2017-04-24 19:11:30 PDT
Comment on attachment 255325 [details] Patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant.
Note You need to log in before you can comment on or make changes to this bug.