Bug 146184

Summary: [SOUP] Use GTask in WebKitSoupRequestInputStream
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit2Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146181
https://bugs.webkit.org/show_bug.cgi?id=117149
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2015-06-20 14:15:25 PDT
Replace use of GSimpleAsyncResult with GTask in WebKitSoupRequestInputStream.
Attachments
Patch (5.89 KB, patch)
2015-06-20 14:21 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (5.90 KB, patch)
2015-06-21 05:23 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2015-06-20 14:21:07 PDT
Created attachment 255298 [details] Patch
Carlos Garcia Campos
Comment 2 2015-06-21 02:29:03 PDT
Comment on attachment 255298 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255298&action=review > Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:85 > + GRefPtr<GTask> task = adoptGRef(g_task_new(G_OBJECT(stream), cancellable, callback, userData)); g_task_new expects a gpointer so we don't need the G_OBJECT cast.
Michael Catanzaro
Comment 3 2015-06-21 05:23:36 PDT
Created attachment 255323 [details] Patch
WebKit Commit Bot
Comment 4 2015-06-21 06:20:05 PDT
Comment on attachment 255323 [details] Patch Clearing flags on attachment: 255323 Committed r185808: <http://trac.webkit.org/changeset/185808>
WebKit Commit Bot
Comment 5 2015-06-21 06:20:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.