Bug 146184

Summary: [SOUP] Use GTask in WebKitSoupRequestInputStream
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKit2Assignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cgarcia, commit-queue, mcatanzaro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=146181
https://bugs.webkit.org/show_bug.cgi?id=117149
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2015-06-20 14:15:25 PDT
Replace use of GSimpleAsyncResult with GTask in WebKitSoupRequestInputStream.
Comment 1 Michael Catanzaro 2015-06-20 14:21:07 PDT
Created attachment 255298 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-06-21 02:29:03 PDT
Comment on attachment 255298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255298&action=review

> Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:85
> +    GRefPtr<GTask> task = adoptGRef(g_task_new(G_OBJECT(stream), cancellable, callback, userData));

g_task_new expects a gpointer so we don't need the G_OBJECT cast.
Comment 3 Michael Catanzaro 2015-06-21 05:23:36 PDT
Created attachment 255323 [details]
Patch
Comment 4 WebKit Commit Bot 2015-06-21 06:20:05 PDT
Comment on attachment 255323 [details]
Patch

Clearing flags on attachment: 255323

Committed r185808: <http://trac.webkit.org/changeset/185808>
Comment 5 WebKit Commit Bot 2015-06-21 06:20:08 PDT
All reviewed patches have been landed.  Closing bug.