Bug 146181 – [EFL][GTK] Define GLIB_VERSION_MIN_REQUIRED and require glib 2.36 for GTK

• Component: Web Template Framework
• Status: RESOLVED FIXED

[Michael Catanzaro]

Define GLIB_VERSION_MIN_REQUIRED to silence more deprecation warnings.

[Michael Catanzaro]

Created attachment 255291 [details]
Patch

[Michael Catanzaro]

This fixes the following deprecation warnings that cannot otherwise be fixed without bumping the GTK port's GLib requirement from 2.34 to 2.36 (to gain access to GTask, the replacement for GSimpleAsyncResult):

[4164/4532] Building CXX object Source...oup/WebKitSoupRequestInputStream.cpp.o
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:57:9: warning: 'g_simple_async_result_set_op_res_gssize' is deprecated [-Wdeprecated-declarations]
        g_simple_async_result_set_op_res_gssize(result, bytesRead);
        ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:82:21: note: 'g_simple_async_result_set_op_res_gssize' has been explicitly marked deprecated here
void                g_simple_async_result_set_op_res_gssize   (GSimpleAsyncResult      *simple,
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:60:9: warning: 'g_simple_async_result_take_error' is deprecated [-Wdeprecated-declarations]
        g_simple_async_result_take_error(result, error);
        ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:116:21: note: 'g_simple_async_result_take_error' has been explicitly marked deprecated here
void                g_simple_async_result_take_error       (GSimpleAsyncResult      *simple,
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:61:5: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
    g_simple_async_result_complete_in_idle(result);
    ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: 'g_simple_async_result_complete_in_idle' has been explicitly marked deprecated here
void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:87:52: warning: 'g_simple_async_result_new' is deprecated [-Wdeprecated-declarations]
    GRefPtr<GSimpleAsyncResult> result = adoptGRef(g_simple_async_result_new(G_OBJECT(stream), callback, userData, reinterpret_cast<void*>(webkitSoupRequestInputStreamReadAsync)));
                                                   ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:51:21: note: 'g_simple_async_result_new' has been explicitly marked deprecated here
GSimpleAsyncResult *g_simple_async_result_new              (GObject                 *source_object,
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:92:9: warning: 'g_simple_async_result_set_op_res_gssize' is deprecated [-Wdeprecated-declarations]
        g_simple_async_result_set_op_res_gssize(result.get(), 0);
        ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:82:21: note: 'g_simple_async_result_set_op_res_gssize' has been explicitly marked deprecated here
void                g_simple_async_result_set_op_res_gssize   (GSimpleAsyncResult      *simple,
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:93:9: warning: 'g_simple_async_result_complete_in_idle' is deprecated [-Wdeprecated-declarations]
        g_simple_async_result_complete_in_idle(result.get());
        ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:106:21: note: 'g_simple_async_result_complete_in_idle' has been explicitly marked deprecated here
void                g_simple_async_result_complete_in_idle (GSimpleAsyncResult      *simple);
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:108:20: warning: 'g_simple_async_result_get_source_tag' is deprecated [-Wdeprecated-declarations]
    g_warn_if_fail(g_simple_async_result_get_source_tag(simpleResult) == webkitSoupRequestInputStreamReadAsync);
                   ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/glib/gmessages.h:303:18: note: expanded from macro 'g_warn_if_fail'
    if G_LIKELY (expr) ; \
                 ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/glib/gmacros.h:329:25: note: expanded from macro 'G_LIKELY'
#define G_LIKELY(expr) (expr)
                        ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:99:21: note: 'g_simple_async_result_get_source_tag' has been explicitly marked deprecated here
gpointer            g_simple_async_result_get_source_tag   (GSimpleAsyncResult      *simple);
                    ^
../../Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp:110:12: warning: 'g_simple_async_result_get_op_res_gssize' is deprecated [-Wdeprecated-declarations]
    return g_simple_async_result_get_op_res_gssize(simpleResult);
           ^
/home/mcatanzaro/jhbuild/install/include/glib-2.0/gio/gsimpleasyncresult.h:85:21: note: 'g_simple_async_result_get_op_res_gssize' has been explicitly marked deprecated here
gssize              g_simple_async_result_get_op_res_gssize   (GSimpleAsyncResult      *simple);
                    ^
8 warnings generated.

[Michael Catanzaro]

Um, actually, we use GTask all over the place. Let's bump our minimum to 2.36 to reflect reality.

One point to Carloz Lopez!

[Michael Catanzaro]

Created attachment 255292 [details]
Patch

[Michael Catanzaro]

(In reply to comment #3) 
> One point to Carloz Lopez!

(This was just a typo.)

[Martin Robinson]

How long have we depended on something beyond our minimum dependencies?

[Michael Catanzaro]

We've used GTask for 24 months and one day (to be unnecessarily precise). See the bugs tracked by bug #117149, which notes that "now we depend on glib 2.36." I guess at some point (maybe during the build system switch) our version requirement went backwards by accident.

[WebKit Commit Bot]

Comment on attachment 255292 [details]
Patch

Clearing flags on attachment: 255292

Committed r185802: <http://trac.webkit.org/changeset/185802>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Garcia Campos]

(In reply to comment #6)
> How long have we depended on something beyond our minimum dependencies?

Never. We agreed on depending on 2.36.0 since WebKitGTK+ 2.0.0

https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001387.html
https://bugs.webkit.org/show_bug.cgi?id=113282
http://trac.webkit.org/changeset/147547