Bug 146162 – WKFrameInfo should have an accessor for the Frame's current security origin

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

WKFrameInfo should have an accessor for the Frame's current security origin

This also involves promoting _WKSecurityOrigin SPI to WKSecurityOrigin API

[Brady Eidson]

Created attachment 255225 [details]
Patch v1

[WebKit Commit Bot]

Attachment 255225 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 255225 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=255225&action=review

> Source/WebKit2/UIProcess/API/APIFrameInfo.cpp:37
> +    , m_securityOrigin(securityOrigin ? securityOrigin->isolatedCopy() : WebCore::SecurityOrigin::create(m_request.url()))

I don’t know why it’s correct to use the frame’s URL in this case. Since there exist frames where the URL differs from the security origin, this code makes it easy to do the wrong thing.

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:61
> +        _wkSecurityOrigin = adoptNS([[_WKSecurityOrigin alloc] _initWithSecurityOrigin:_frameInfo->securityOrigin()]);

We can make a WKSecurityOrigin here, I think, no need to make a _WKSecurityOrigin.

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:48
> +    RetainPtr<WKSecurityOrigin> _wkSecurityOrigin;

Hmm… we normally don’t give our wrappers extra ivars. I think we don’t need to have this cache.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:35
> + @discussion An instance of this class is a transient, data-only object;
> + it does not uniquely identify a security origin across multiple delegate method
> + calls.

Seems like we could easily implement -isEqual: and -hash here to make this comment unnecessary.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:40
> +@interface WKSecurityOrigin : NSObject <NSCopying>

Not sure we need NSCopying.

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:30
> +#import <wtf/PassRefPtr.h>

Is this #import needed here?

> Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:33
> +class ResourceRequest;

This forward declaration is unused.

> Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.mm:34
>  @implementation _WKSecurityOrigin {
> -    RefPtr<WebCore::SecurityOrigin> _origin;
>  }

Can get rid of the braces as well.

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 255225 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255225&action=review
> 
> > Source/WebKit2/UIProcess/API/APIFrameInfo.cpp:37
> > +    , m_securityOrigin(securityOrigin ? securityOrigin->isolatedCopy() : WebCore::SecurityOrigin::create(m_request.url()))
> 
> I don’t know why it’s correct to use the frame’s URL in this case. Since
> there exist frames where the URL differs from the security origin, this code
> makes it easy to do the wrong thing.

I believe it would be preventatively difficult to always have the correct security origin available in the UI process.

So we can either manufacture an origin that will be right most of the time, which is a lie...
Or we can optionally return a nil origin, which is wrong all of the time, because there actually is always an origin.

Is there another alternative I am missing?

> > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:61
> > +        _wkSecurityOrigin = adoptNS([[_WKSecurityOrigin alloc] _initWithSecurityOrigin:_frameInfo->securityOrigin()]);
> 
> We can make a WKSecurityOrigin here, I think, no need to make a
> _WKSecurityOrigin.

Right. Changed.

> > Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:48
> > +    RetainPtr<WKSecurityOrigin> _wkSecurityOrigin;
> 
> Hmm… we normally don’t give our wrappers extra ivars. I think we don’t need
> to have this cache.

We wouldn't normally have an accessor return a different object each time you ask, either.

While the object is transient, data-only... it would be very strange to have the following:

// ... passed in some WKFrameInfo called 'frameInfo'
WKSecurityOrigin *origin1 [frameInfo securityOrigin];
WKSecurityOrigin *origin2 [frameInfo securityOrigin];
if (origin1 != origin2)
    NSLog(@"Huh?");

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:35
> > + @discussion An instance of this class is a transient, data-only object;
> > + it does not uniquely identify a security origin across multiple delegate method
> > + calls.
> 
> Seems like we could easily implement -isEqual: and -hash here to make this
> comment unnecessary.

I'm not sure the comment is about the lack of isEqual and hash. It's to stress that you shouldn't expect to get the same object across two delegate calls even if the underlying object has not actually changed.

FWIW, I cribbed this comment from WKFrameInfo which has the exact same consideration.

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOrigin.h:40
> > +@interface WKSecurityOrigin : NSObject <NSCopying>
> 
> Not sure we need NSCopying.

I suppose not. Removed

> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:30
> > +#import <wtf/PassRefPtr.h>
> 
> Is this #import needed here?

No, sorry. Is needed somewhere else. This file changed over development.
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKSecurityOriginInternal.h:33
> > +class ResourceRequest;
> 
> This forward declaration is unused.

Right. Also leftovers.

> > Source/WebKit2/UIProcess/API/Cocoa/_WKSecurityOrigin.mm:34
> >  @implementation _WKSecurityOrigin {
> > -    RefPtr<WebCore::SecurityOrigin> _origin;
> >  }
> 
> Can get rid of the braces as well.

Oh, maybe! Didn't even think to try.

[Brady Eidson]

In person, discussed a few of these, came to good resolutions.

Next patch coming sometime soonish, in the next few days.

[Brady Eidson]

Created attachment 255280 [details]
Patch v2

[WebKit Commit Bot]

Attachment 255280 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:163:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:177:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:220:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 255280 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=255280&action=review

r=me with minor comments below.

> Source/WebKit2/ChangeLog:10
> +        - Makes the WKSecurityOrigin Cocoa API object with with API::SecurityOrigin.

with with?

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:1852
> +        virtual void didFailProvisionalLoadInSubframeWithError(WebPageProxy& page, WebFrameProxy& subframe, const WebKit::SecurityOriginData& securityOriginData, API::Navigation* navigation, const WebCore::ResourceError& error, API::Object* userData) override

No need for WebKit:: here

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:32
> +#import "WKSecurityOriginInternal.h"
> +#import "_WKSecurityOrigin.h"

Do we need both of these?

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h:32
> +#import "WKRetainPtr.h"

?

> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:88
> +    virtual void didPostMessage(WebKit::WebPageProxy& page, WebKit::WebFrameProxy& frame, const WebKit::SecurityOriginData& securityOriginData, WebCore::SerializedScriptValue& serializedScriptValue)

No need for WebKit:: here.

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:31
> +#import "APISecurityOrigin.h"

This is imported by WKSecurityOriginInternal.h below.

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:43
> +#import "_WKSecurityOrigin.h"

Still need this?

> Source/WebKit2/UIProcess/UserContent/WebScriptMessageHandler.h:61
> +        virtual void didPostMessage(WebPageProxy&, WebFrameProxy&, const WebKit::SecurityOriginData&, WebCore::SerializedScriptValue&) = 0;

No need for WebKit:: here.

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:439
> +    SecurityOriginData originData;
> +    if (Document* document = frame->document()) {
> +        if (SecurityOrigin* origin = document->securityOrigin())
> +            originData = SecurityOriginData::fromSecurityOrigin(*origin);
> +    }
> +

Can pull this into a static function instead of repeating it four times?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:840
> +    SecurityOriginData originatingOriginData;
> +    if (Document* document = originatingFrame->coreFrame()->document()) {
> +        if (SecurityOrigin* origin = document->securityOrigin())
> +            originatingOriginData = SecurityOriginData::fromSecurityOrigin(*origin);
> +    }

Wow, even more of this. Maybe it can be a static function in SecurityOriginData?

[Build Bot]

Comment on attachment 255280 [details]
Patch v2

Attachment 255280 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4569267521454080

New failing tests:
inspector/model/parse-script-syntax-tree.html
http/tests/inspector/css/bad-mime-type.html
inspector/css/matched-style-properties.html
inspector/console/console-api.html
http/tests/navigation/post-redirect-get-reload.php
inspector/event-listener.html
inspector/protocol-promise-result.html
inspector/console/console-table.html
fast/loader/onload-policy-ignore-for-frame.html
inspector/test-harness-trivially-works.html
inspector/css/pseudo-element-matches.html
inspector/css/selector-specificity.html
fast/loader/window-open-to-invalid-url-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
inspector/event-listener-set.html

[Build Bot]

Created attachment 255281 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Brady Eidson]

(In reply to comment #7)
> Attachment 255280 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before
> {  [whitespace/braces] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one
> command on the same line  [whitespace/newline] [4]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type
> should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:123:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:143:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:157:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:163:  Extra space before
> ( in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:177:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:220:  Place brace on its
> own line for function definitions.  [whitespace/braces] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before (
> in function call  [whitespace/parens] [4]
> ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before (
> in function call  [whitespace/parens] [4]
> Total errors found: 26 in 38 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

These are all bull, as check-webkit-style does not understand C++ lambdas, etc

[Brady Eidson]

(In reply to comment #8)
> Comment on attachment 255280 [details]
> Patch v2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255280&action=review
> 
> r=me with minor comments below.


I'll address all of these before landing.

[Brady Eidson]

(In reply to comment #9)
> Comment on attachment 255280 [details]
> Patch v2
> 
> Attachment 255280 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/4569267521454080
> 
> New failing tests:
> inspector/model/parse-script-syntax-tree.html
> http/tests/inspector/css/bad-mime-type.html
> inspector/css/matched-style-properties.html
> inspector/console/console-api.html
> http/tests/navigation/post-redirect-get-reload.php
> inspector/event-listener.html
> inspector/protocol-promise-result.html
> inspector/console/console-table.html
> fast/loader/onload-policy-ignore-for-frame.html
> inspector/test-harness-trivially-works.html
> inspector/css/pseudo-element-matches.html
> inspector/css/selector-specificity.html
> fast/loader/window-open-to-invalid-url-disallowed.html
> fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
> inspector/event-listener-set.html

And... I'll make sure these aren't my-bad.

[Brady Eidson]

Created attachment 255310 [details]
EWS run

[WebKit Commit Bot]

Attachment 255310 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1406:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1417:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1428:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1142:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1143:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1144:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 255379 [details]
New EWS run

[WebKit Commit Bot]

Attachment 255379 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1411:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1422:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1145:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1146:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1147:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 255413 [details]
EWS + CQ

[WebKit Commit Bot]

Attachment 255413 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:66:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1411:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1422:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:1433:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3467:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3475:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3478:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3486:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3489:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:3497:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1145:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1146:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1147:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:121:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:141:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:155:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:161:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:175:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:196:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:218:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:84:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:85:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/APIUIClient.h:86:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 26 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

This test failure:
Regressions: Unexpected image-only failures (1)
  compositing/masks/compositing-clip-path-origin.html [ ImageOnlyFailure ]

is not from this patch...

[WebKit Commit Bot]

Comment on attachment 255413 [details]
EWS + CQ

Clearing flags on attachment: 255413

Committed r185877: <http://trac.webkit.org/changeset/185877>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.