Bug 146158 – Add a JSC symlink in /System/Library/PrivateFrameworks

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Add a JSC symlink in /System/Library/PrivateFrameworks

[Anders Carlsson]

Created attachment 255219 [details]
Patch

Comment on attachment 255219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255219&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:6782
> +			runOnlyForDeploymentPostprocessing = 0;

I think you want to run this only when installing.

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:6784
> +			shellScript = "if [[ ${PLATFORM_NAME} == \"iphoneos\" || ${PLATFORM_NAME} == \"iphonesimulator\" ]]; then\nif [[ ! -d \"${INSTALL_DIR}/../PrivateFrameworks\" ]]; then\nmkdir -p \"${INSTALL_DIR}/../PrivateFrameworks\"\nfi\nif [[ -d \"${INSTALL_DIR}/../PrivateFrameworks/JavaScriptCore.framework\" && ! -L \"${INSTALL_DIR}/../PrivateFrameworks/JavaScriptCore.framework\" ]]; then\necho \"ERROR: Cannot create symlink. ${INSTALL_DIR}/../PrivateFrameworks/JavaScriptCore.framework already exists and is a directory.\"\nexit 1\nfi\n# If the symlink already exists, remove it and create the new one in its place.\nln -s -h -f ../Frameworks/JavaScriptCore.framework ${INSTALL_DIR}/../PrivateFrameworks/JavaScriptCore.framework\nfi";

There’s no need to do this for iphonesimulator, only iphoneos. Instead of using ${INSTALL_DIR}, I’d use paths relative to  ${INSTALL_ROOT}/${SYSTEM_LIBRARY_DIR}, like in WebKit2. I think the “If the symlink already exists” comment isn’t helpful. Not sure checking for the “exists and is a directory” case is necessary, especially for something that’s only done when installing.

[Anders Carlsson]

Created attachment 255222 [details]
Patch

[Anders Carlsson]

Committed r185765: <http://trac.webkit.org/changeset/185765>