Summary: | JetStream should include a JavaScript version of the CDx real-time benchmark | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | Tools / Tests | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-06-19 13:16:28 PDT
Created attachment 255221 [details]
the patch
Attachment 255221 [details] did not pass style-queue:
ERROR: PerformanceTests/JetStream/cdjs/motion.js:61: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:62: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:63: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:64: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:65: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:66: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:67: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:68: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:69: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:70: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:71: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:72: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:73: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:74: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:75: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:76: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:77: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:78: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:79: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:80: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:81: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/motion.js:82: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/reduce_collision_set.js:103: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/reduce_collision_set.js:105: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/reduce_collision_set.js:106: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/reduce_collision_set.js:108: Line contains tab character. [whitespace/tab] [5]
ERROR: PerformanceTests/JetStream/cdjs/reduce_collision_set.js:109: Line contains tab character. [whitespace/tab] [5]
Total errors found: 27 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 255221 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=255221&action=review r=me > PerformanceTests/JetStream/cdjs/motion.js:94 > + var b = 2 * init1.minus(init2).dot(vec1.minus(vec2)); > + > + // c = -r^2 + (I2 - I1)^T * (I2 - I1) > + var c = -radius * radius + init2.minus(init1).squaredMagnitude(); > + > + var discr = b * b - 4 * a * c; > + if (discr < 0) > + return null; > + > + var v1 = (-b - Math.sqrt(discr)) / (2 * a); > + var v2 = (-b + Math.sqrt(discr)) / (2 * a); This indentation looks off. Created attachment 255244 [details]
patch for landing
I think I got rid of all of those tabs that were messing up indentation.
Landed in http://trac.webkit.org/changeset/185780 |