Bug 146147

Summary:

[WinCairo] Null pointer crash in BitmapTexture::updateContents.

Product:

WebKit

Reporter:

peavo

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, cmarcelo, commit-queue, kondapallykalyan, luiz, noam, ossy, ys.suh

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=22132

Attachments:

Description	Flags
Patch	none

peavo

Reported 2015-06-19 07:19:29 PDT

When I have a lot of WebViews open, and memory usage is high (> 700MB), I often get a null pointer exception in BitmapTexture::updateContents.

Attachments
Patch (1.50 KB, patch) 2015-06-19 07:22 PDT, peavo	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2015-06-19 07:22:56 PDT

Created attachment 255190 [details] Patch

Brent Fulgham

Comment 2 2015-06-19 09:07:09 PDT

Comment on attachment 255190 [details] Patch r=me.

Brent Fulgham

Comment 3 2015-06-19 09:08:41 PDT

It looks like this null check is missing in a few places system-wide (not just WinCairo).

Brent Fulgham

Comment 4 2015-06-19 09:43:04 PDT

This bug was originally reported back in 2008! See Bug 22132. :-)

WebKit Commit Bot

Comment 5 2015-06-19 10:14:11 PDT

Comment on attachment 255190 [details] Patch Clearing flags on attachment: 255190 Committed r185752: <http://trac.webkit.org/changeset/185752>

WebKit Commit Bot

Comment 6 2015-06-19 10:14:16 PDT

All reviewed patches have been landed. Closing bug.

peavo

Comment 7 2015-06-19 23:07:41 PDT

(In reply to comment #2) > Comment on attachment 255190 [details] > Patch > > r=me. Thanks!

peavo

Comment 8 2015-06-19 23:53:01 PDT

(In reply to comment #4) > This bug was originally reported back in 2008! See Bug 22132. :-) Thanks for fixing this, Brent :)

Fujii Hironori

Comment 9 2022-06-21 20:12:21 PDT

*** Bug 102011 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.