Bug 146147

Summary: [WinCairo] Null pointer crash in BitmapTexture::updateContents.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cmarcelo, commit-queue, kondapallykalyan, luiz, noam, ossy, ys.suh
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=22132
Attachments:
Description Flags
Patch none

Description peavo 2015-06-19 07:19:29 PDT 
When I have a lot of WebViews open, and memory usage is high (> 700MB), I often get a null pointer exception in BitmapTexture::updateContents.
Comment 1 peavo 2015-06-19 07:22:56 PDT 
Created attachment 255190 [details]
Patch
Comment 2 Brent Fulgham 2015-06-19 09:07:09 PDT 
Comment on attachment 255190 [details]
Patch

r=me.
Comment 3 Brent Fulgham 2015-06-19 09:08:41 PDT 
It looks like this null check is missing in a few places system-wide (not just WinCairo).
Comment 4 Brent Fulgham 2015-06-19 09:43:04 PDT 
This bug was originally reported back in 2008! See Bug 22132. :-)
Comment 5 WebKit Commit Bot 2015-06-19 10:14:11 PDT 
Comment on attachment 255190 [details]
Patch

Clearing flags on attachment: 255190

Committed r185752: <http://trac.webkit.org/changeset/185752>
Comment 6 WebKit Commit Bot 2015-06-19 10:14:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 peavo 2015-06-19 23:07:41 PDT 
(In reply to comment #2)
> Comment on attachment 255190 [details]
> Patch
> 
> r=me.

Thanks!
Comment 8 peavo 2015-06-19 23:53:01 PDT 
(In reply to comment #4)
> This bug was originally reported back in 2008! See Bug 22132. :-)

Thanks for fixing this, Brent :)
Comment 9 Fujii Hironori 2022-06-21 20:12:21 PDT 
*** Bug 102011 has been marked as a duplicate of this bug. ***