Bug 146143

Summary: [WK2] ConnectionUnix should use FastMalloc to allocate on-heap resources
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mrobinson, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2015-06-18 23:46:11 PDT 
[WK2] ConnectionUnix should use FastMalloc to allocate on-heap resources
Comment 1 Zan Dobersek 2015-06-19 00:00:31 PDT 
Created attachment 255180 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-19 00:03:43 PDT 
Attachment 255180 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:449:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2015-06-19 00:37:55 PDT 
Comment on attachment 255180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255180&action=review

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:451
> +        size_t attachmentFDBufferLength = std::count_if(attachments.begin(), attachments.end(),
> +            [](const Attachment& attachment) {
> +                return attachment.fileDescriptor() != -1;
> +            });

Cool
Comment 4 Zan Dobersek 2015-06-22 05:07:34 PDT 
Comment on attachment 255180 [details]
Patch

Clearing flags on attachment: 255180

Committed r185824: <http://trac.webkit.org/changeset/185824>
Comment 5 Zan Dobersek 2015-06-22 05:07:51 PDT 
All reviewed patches have been landed.  Closing bug.