| Summary: | Get CAContext directly for CALayer instead of walking the layer tree. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||||
| Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, simon.fraser, thorton | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jeremy Jones
2015-06-18 21:18:44 PDT
Created attachment 255169 [details]
Patch
Comment on attachment 255169 [details]
Patch
I can't review this without some more explanation in the changelog.
Comment on attachment 255169 [details]
Patch
Seems clearly more efficient and straightforward. Does it also fix any bugs? Can we make a regression test for the bugs it fixes?
(In reply to comment #4) > Comment on attachment 255169 [details] > Patch > > Seems clearly more efficient and straightforward. Does it also fix any bugs? > Can we make a regression test for the bugs it fixes? I don't know of any concrete failures that this fixes, only the hunch that the convoluted approach might fail where the direct approach would succeed. Created attachment 255203 [details]
Patch for landing.
(In reply to comment #3) > Comment on attachment 255169 [details] > Patch > > I can't review this without some more explanation in the changelog. Added more explanation. Comment on attachment 255203 [details] Patch for landing. Clearing flags on attachment: 255203 Committed r185763: <http://trac.webkit.org/changeset/185763> |