Bug 146117

Summary: Fix crash when entering fullscreen during exit fullscreen animation.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: WebKit2Assignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing. none

Description Jeremy Jones 2015-06-18 12:26:58 PDT 
Fix crash when entering fullscreen during exit fullscreen animation.
Comment 1 Jeremy Jones 2015-06-18 12:36:04 PDT 
Created attachment 255123 [details]
Patch
Comment 2 Jeremy Jones 2015-06-18 12:36:58 PDT 
rdar://problem/20692847
Comment 3 Simon Fraser (smfr) 2015-06-18 13:45:36 PDT 
Comment on attachment 255123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255123&action=review

> Source/WebCore/ChangeLog:8
> +        If exitFullscreen is called from javascript, it may be called from mainThread.

I don't think this line adds anything.
Comment 4 Jeremy Jones 2015-06-18 15:43:33 PDT 
Created attachment 255144 [details]
Patch for landing.
Comment 5 Jeremy Jones 2015-06-18 15:43:51 PDT 
(In reply to comment #3)
> Comment on attachment 255123 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255123&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        If exitFullscreen is called from javascript, it may be called from mainThread.
> 
> I don't think this line adds anything.

Removed.
Comment 6 WebKit Commit Bot 2015-06-18 16:39:38 PDT 
Comment on attachment 255144 [details]
Patch for landing.

Clearing flags on attachment: 255144

Committed r185726: <http://trac.webkit.org/changeset/185726>