Bug 146108

Summary: [EFL] Use SET_AND_EXPOSE_TO_BUILD instead of definitions
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2015-06-18 04:37:50 PDT
Since r183416, OptionsGTK uses SET_AND_EXPOSE_TO_BUILD to add definitions to both CMake and compiler. EFL port also can use it to simplify definitions.
Attachments
Patch (3.43 KB, patch)
2015-06-18 04:41 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-06-18 04:41:23 PDT
Created attachment 255107 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-18 07:26:06 PDT
Comment on attachment 255107 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2015-06-18 16:36:07 PDT
Comment on attachment 255107 [details] Patch Clearing flags on attachment: 255107 Committed r185725: <http://trac.webkit.org/changeset/185725>
WebKit Commit Bot
Comment 4 2015-06-18 16:36:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.