|
Description
Jon Lee
2015-06-17 19:40:17 PDT
Uploading several sub-patches for review, and one large one that is the combination of all of them, for EWS to chew on. Created attachment 255062 [details]
Refactor allowsOptimizedFullscreen, set bool with member instead of local var.
Created attachment 255063 [details]
Update delegate calls
Created attachment 255064 [details]
Replace start/stop PiP
Created attachment 255065 [details]
isPiPPossible
Created attachment 255066 [details]
prepareForPictureInPictureStopWithCompletionHandler
Created attachment 255067 [details]
enterFullscreenOptimized
Created attachment 255068 [details]
remove unused setIsOptimized
Created attachment 255069 [details]
Change media player enum to VideoFullscreenModePictureInPicture
Created attachment 255070 [details]
Remove unused AVPlayerViewControllerOptimizedFullscreenStopReason
Created attachment 255071 [details]
Replace wkIsOptimizedFullscreenSupported
Created attachment 255072 [details]
Replace AVPlayerLayer setEnterOptimizedFullscreenModeEnabled
Created attachment 255073 [details]
Update local variable names
Created attachment 255074 [details]
Update mayAutomaticallyShowVideoOptimized
Created attachment 255075 [details]
Replace _isShowingVideoOptimized and _mayAutomaticallyShowVideoOptimized
Created attachment 255076 [details]
Update setting to allowsPictureInPictureMediaPlayback
Created attachment 255077 [details]
Update MediaElementSession::allowsAlternateFullscreen
Created attachment 255078 [details]
Add WebPreferences allowsPictureInPictureMediaPlayback; refactor alternate fullscreen to use that. Later patch will remove the preference since it is being used by another framework
Created attachment 255079 [details]
Update shouldAllowAlternateFullscreen
Created attachment 255090 [details]
Patch for submission
*** Bug 146094 has been marked as a duplicate of this bug. *** 19 r? in one bug report? :o I'm not sure if it is a good idea. The latest patch aggregates the previous smaller patch, am I right? Please remove the r? flags and set the obsolete flags on the other patches. (In reply to comment #1) > Uploading several sub-patches for review, and one large one that is the > combination of all of them, for EWS to chew on. It's not good at all, the common way is to upload only one patch per bug report. Additionally a patch without changelog entry is insufficient. Comment on attachment 255090 [details]
Patch for submission
Did you miss an instance in Settings.in?
(In reply to comment #24) > Comment on attachment 255090 [details] > Patch for submission > > Did you miss an instance in Settings.in? No, this is another case where the builders don't update the generated settings files appropriately. I ran into this before when renaming the other media settings. It builds fine on my machine; I'll keep an eye on the bots. I am going to check in a version of the patch that does not include the update to WKSI. That call should be removed. I'll file another bug to track that. Created attachment 255142 [details]
Patch
Created attachment 255149 [details]
Patch for submission
Committed r185727: <http://trac.webkit.org/changeset/185727> |