Bug 146074

Summary:

Client may receive began editing callback for already focused text field

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, jberlin, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch and unit test	none

Daniel Bates

Reported 2015-06-17 13:11:35 PDT

An embedding client should only receive a began editing callback when a text field is newly focused. That is, subsequently focusing the text field by dispatching a programmatic DOM focus event at it should not dispatch a began editing callback.

Attachments
Patch and unit test (5.24 KB, patch) 2015-06-17 13:30 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2015-06-17 13:12:43 PDT

<rdar://problem/21293562>

Daniel Bates

Comment 2 2015-06-17 13:30:33 PDT

Created attachment 255032 [details] Patch and unit test We should look to further clean up TextFieldInputType::forwardEvent(), including moving the logic to update the caps lock indicator state from TextFieldInputType::forwardEvent() to TextFieldInputType::handle{Blur, Focus}Event(). I suggest we do such clean up in another bug.

Daniel Bates

Comment 3 2015-06-17 21:39:39 PDT

Comment on attachment 255032 [details] Patch and unit test Clearing flags on attachment: 255032 Committed r185692: <http://trac.webkit.org/changeset/185692>

Daniel Bates

Comment 4 2015-06-17 21:39:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.