Bug 146059

Summary: GObject and ObjC bindings generator should not generate code for promise-based APIs
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2015-06-17 06:18:30 PDT
In case of a function returning a promise, GObject and ObjC may generate bindings for that function. The issue is that the returned type Promise may not be supported yet. It may be safer to disable binding generation for these functions, at least until Promise returned values are support by GObject and ObjC
Attachments
Patch (5.99 KB, patch)
2015-06-17 06:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2015-06-17 06:24:17 PDT
Created attachment 255014 [details] Patch
Darin Adler
Comment 2 2015-06-17 15:23:35 PDT
Comment on attachment 255014 [details] Patch Seems OK for now since we don’t have a strategy for binding these yet.
WebKit Commit Bot
Comment 3 2015-06-18 00:03:40 PDT
Comment on attachment 255014 [details] Patch Clearing flags on attachment: 255014 Committed r185694: <http://trac.webkit.org/changeset/185694>
WebKit Commit Bot
Comment 4 2015-06-18 00:03:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.