Bug 146057

Summary: [GTK] [Wayland] Build by default the X11 and Wayland targets.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, darin, mcatanzaro, mrobinson, pnormand, svillar, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145701, 146056, 146740, 147559    
Bug Blocks: 81456    
Attachments:
Description Flags
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2015-06-17 05:10:52 PDT
In order to give proper testing to the Wayland target, enable building by default both the X11 and Wayland targets on the GTK port.
Attachments
Patch (1.67 KB, patch)
2015-07-13 17:45 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2015-07-13 18:21 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2015-07-13 17:41:32 PDT
I have tested the following: - build the x11 targets alone (current default) and run the layout tests twice to discard flaky tests. - build both targets (x11 and wayland) and run the layout tests (for xvfb/x11) twice to discard flaky tests. + compare the results in both cases: I don't observe differences. So, I will upload a patch for review turning on the switch.
Carlos Alberto Lopez Perez
Comment 2 2015-07-13 17:45:33 PDT
Created attachment 256749 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2015-07-13 18:21:09 PDT
Created attachment 256754 [details] Patch Add headers of wayland to script install-dependencies.
Michael Catanzaro
Comment 4 2015-07-13 19:25:45 PDT
:)
Carlos Alberto Lopez Perez
Comment 5 2015-07-14 01:47:14 PDT
Comment on attachment 256754 [details] Patch Clearing flags on attachment: 256754 Committed r186800: <http://trac.webkit.org/changeset/186800>
Carlos Alberto Lopez Perez
Comment 6 2015-07-14 01:47:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.