| Summary: | Web Inspector: Improve a few more node preview types | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 146114 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 255001 [details]
[PATCH] Proposed Fix
I considered improving
#text "foo"
To also have a red string for "foo", but decided against it, we didn't previously in any case.
Comment on attachment 255001 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255001 Committed r185671: <http://trac.webkit.org/changeset/185671> All reviewed patches have been landed. Closing bug. Looks like this caused flaky failures on all bots (closer to always failing, in fact): https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fprofiler%2Fbuilt-in-function-calls-user-defined-function.html https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fprofiler%2Fbuilt-in-function-calls-anonymous.html I think that this needs to be rolled out. Re-opened since this is blocked by bug 146114 Re-landed in: http://trac.webkit.org/changeset/185716 |
* SUMMARY Improve a few more node preview types (comment, and doctype). * TEST js> [document.createElement("div"), document.createComment("test"), document.doctype, document, document.createTextNode("text"), document.createDocumentFragment(), document.createAttribute("attr")] We should make the comment and doctype nodes appear nicer than we currently do.