Bug 146046

Summary:

[EFL] test_ewk2_context has been failed since r185529

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lucas.de.marchi, ossy, ryuan.choi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

146075

Bug Blocks:

132813

Attachments:

Description	Flags
Patch	none
Patch	none
Patch for landing	none

Gyuyoung Kim

Reported 2015-06-16 21:36:44 PDT

We need to investigate this problem as soon as possible.

Attachments
Patch (2.88 KB, patch) 2015-06-16 22:25 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (2.33 KB, patch) 2015-06-17 22:56 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (2.33 KB, patch) 2015-06-18 01:08 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2015-06-16 22:25:53 PDT

Created attachment 255000 [details] Patch

Ryuan Choi

Comment 2 2015-06-17 14:20:28 PDT

I will cover ewk2_context_scheme_register in Bug 146075

Gyuyoung Kim

Comment 3 2015-06-17 17:23:56 PDT

(In reply to comment #2) > I will cover ewk2_context_scheme_register in Bug 146075 Oh, nice ! If your patch is landed first, I won't disable ewk2_context_scheme_register in this patch.

Gyuyoung Kim

Comment 4 2015-06-17 22:56:41 PDT

Created attachment 255087 [details] Patch

Gyuyoung Kim

Comment 5 2015-06-17 22:57:48 PDT

(In reply to comment #3) > (In reply to comment #2) > > I will cover ewk2_context_scheme_register in Bug 146075 > > Oh, nice ! If your patch is landed first, I won't disable > ewk2_context_scheme_register in this patch. Bug 146075 got r+ faster than this bug :). I update this patch based on Bug 146075.

Csaba Osztrogonác

Comment 6 2015-06-18 01:03:09 PDT

Comment on attachment 255087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review r=me if the test still pass after the typo fix. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216 > + ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID); I think you meant webView_2_NetworkProcessID as the second parameter.

Gyuyoung Kim

Comment 7 2015-06-18 01:08:14 PDT

Created attachment 255099 [details] Patch for landing

Gyuyoung Kim

Comment 8 2015-06-18 01:09:37 PDT

Comment on attachment 255087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216 >> + ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID); > > I think you meant webView_2_NetworkProcessID as the second parameter. Nice catch ! yes, it should be webView2NetworkProcessID. Test is still passed after using webView2NetworkProcessID.

WebKit Commit Bot

Comment 9 2015-06-18 01:57:52 PDT

Comment on attachment 255099 [details] Patch for landing Clearing flags on attachment: 255099 Committed r185696: <http://trac.webkit.org/changeset/185696>

WebKit Commit Bot

Comment 10 2015-06-18 01:57:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.