Summary: | [EFL] test_ewk2_context has been failed since r185529 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | WebKit EFL | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, lucas.de.marchi, ossy, ryuan.choi | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 146075 | ||||||||||
Bug Blocks: | 132813 | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-06-16 21:36:44 PDT
Created attachment 255000 [details]
Patch
I will cover ewk2_context_scheme_register in Bug 146075 (In reply to comment #2) > I will cover ewk2_context_scheme_register in Bug 146075 Oh, nice ! If your patch is landed first, I won't disable ewk2_context_scheme_register in this patch. Created attachment 255087 [details]
Patch
(In reply to comment #3) > (In reply to comment #2) > > I will cover ewk2_context_scheme_register in Bug 146075 > > Oh, nice ! If your patch is landed first, I won't disable > ewk2_context_scheme_register in this patch. Bug 146075 got r+ faster than this bug :). I update this patch based on Bug 146075. Comment on attachment 255087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review r=me if the test still pass after the typo fix. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216 > + ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID); I think you meant webView_2_NetworkProcessID as the second parameter. Created attachment 255099 [details]
Patch for landing
Comment on attachment 255087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255087&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:216 >> + ASSERT_EQ(webView1NetworkProcessID, webView1NetworkProcessID); > > I think you meant webView_2_NetworkProcessID as the second parameter. Nice catch ! yes, it should be webView2NetworkProcessID. Test is still passed after using webView2NetworkProcessID. Comment on attachment 255099 [details] Patch for landing Clearing flags on attachment: 255099 Committed r185696: <http://trac.webkit.org/changeset/185696> All reviewed patches have been landed. Closing bug. |