Bug 146045 – [Cocoa] Draw fonts at their native sizes instead of scaling a 1pt font

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[Cocoa] Draw fonts at their native sizes instead of scaling a 1pt font

[Myles C. Maxfield]

Created attachment 254998 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 254998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254998&action=review

> Source/WebCore/ChangeLog:9
> +        In his WWDC talk[1], Antonio Cavedoni describes how laying out a font at a particular point size
> +        may yield different visual results than laying out a font at a 1pt size into a scaled context.

This patch is about drawing, not layout.

[Sam Weinig]

Is this actually true for any fonts other than the system fonts? If so, can we have a test case?

[Darin Adler]

Comment on attachment 254998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254998&action=review

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:-369
> -    CGAffineTransform matrix = useLetterpressEffect || platformData.isColorBitmapFont() ? CGAffineTransformIdentity : CGAffineTransformMakeScale(fontSize, fontSize);

Did you test these special cases? Does the letterpress effect still work after this? Do color bitmap fonts still work after this?

[Myles C. Maxfield]

On my Yosemite machine, the only color bitmap font is AppleColorEmoji.

[Myles C. Maxfield]

I can't remember if I had already verified this earlier, so I'm re-verifying now. Verified that color bitmap fonts work properly.

[Myles C. Maxfield]

Letterpress can be tested with text-decoration: -webkit-letterpress, but I don't have an iOS build handy to test this on. I'll test later today when I'm at the office.

[Myles C. Maxfield]

Created attachment 260078 [details]
Patch

[Myles C. Maxfield]

Created attachment 260080 [details]
Patch

[Myles C. Maxfield]

Created attachment 260121 [details]
Patch

[Myles C. Maxfield]

Verified that letterpress still works.

[Build Bot]

Comment on attachment 260121 [details]
Patch

Attachment 260121 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/115374

New failing tests:
imported/mozilla/svg/text/simple-fill-gradient.svg
imported/mozilla/svg/text-layout-06.svg
fast/multicol/newmulticol/spanner2.html
fast/regions/region-overflow-auto-overflow-visible.html
svg/custom/hidpi-masking-clipping.svg
fast/text/empty-shadow.html
imported/mozilla/svg/text-scale-02.svg

[Build Bot]

Created attachment 260127 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Committed r189087: <http://trac.webkit.org/changeset/189087>