| Summary: | Safari tabs still have shrunken content after coming out of fullscreen | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, commit-queue, darin, mitz, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2015-06-16 16:57:20 PDT
Created attachment 254980 [details]
Patch
Can you add an API test? (In reply to comment #2) > Can you add an API test? Does seem like a good idea to do that. Also seems worth thinking over whether it’s OK to have a race condition here with these short circuits long term. Created attachment 255029 [details]
Patch
(In reply to comment #3) > (In reply to comment #2) > > Can you add an API test? > > Does seem like a good idea to do that. > > Also seems worth thinking over whether it’s OK to have a race condition here > with these short circuits long term. Agreed! There are a bunch of these (page scale factor also immediately comes to mind), and they always trip me up. Attachment 255029 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:46: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:61: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:76: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|