Bug 146037

Summary: Safari tabs still have shrunken content after coming out of fullscreen
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, mitz, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Tim Horton
Reported 2015-06-16 16:57:20 PDT
Safari tabs still have shrunken content after coming out of fullscreen
Attachments
Patch (4.34 KB, patch)
2015-06-16 16:57 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (12.51 KB, patch)
2015-06-17 12:17 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-06-16 16:57:38 PDT
Created attachment 254980 [details] Patch
mitz
Comment 2 2015-06-16 17:01:38 PDT
Can you add an API test?
Darin Adler
Comment 3 2015-06-16 19:34:37 PDT
(In reply to comment #2) > Can you add an API test? Does seem like a good idea to do that. Also seems worth thinking over whether it’s OK to have a race condition here with these short circuits long term.
Tim Horton
Comment 4 2015-06-17 12:17:23 PDT
Created attachment 255029 [details] Patch
Tim Horton
Comment 5 2015-06-17 12:18:38 PDT
(In reply to comment #3) > (In reply to comment #2) > > Can you add an API test? > > Does seem like a good idea to do that. > > Also seems worth thinking over whether it’s OK to have a race condition here > with these short circuits long term. Agreed! There are a bunch of these (page scale factor also immediately comes to mind), and they always trip me up.
WebKit Commit Bot
Comment 6 2015-06-17 12:18:45 PDT
Attachment 255029 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:46: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:61: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:76: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 7 2015-06-17 12:24:54 PDT
http://trac.webkit.org/changeset/185661
Note You need to log in before you can comment on or make changes to this bug.