Summary: | Web Inspector: Make rule icon toggle all properties for that selector on and off | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Enhancement | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Devin Rousso
2015-06-16 15:27:28 PDT
Created attachment 254972 [details]
Patch
Comment on attachment 254972 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254972&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:72 > + cursor: pointer; This should be a normal cursor. We can use a hover darkening of the icon to indicate clicking behavior. > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:234 > + function uncommentProperties(properties) { Two lines. Created attachment 255129 [details]
Patch
Comment on attachment 255129 [details] Patch Rejecting attachment 255129 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 255129, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: imothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Parsed 5 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 280. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5111003557658624 Created attachment 255206 [details]
Patch
|