Bug 146025 – REGRESSION(r185012): chat frame in Gmail now says "Something's not right"

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

chat frame in GMail now says "Something's not right" after r185012.

Radar: <rdar://problem/21391412>

[Chris Dumez]

Created attachment 254961 [details]
Patch

[Darin Adler]

Comment on attachment 254961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254961&action=review

> Source/WebCore/dom/Document.cpp:2764
> -    double previousInterval = timerAlignmentInterval();
> -
>      m_isTimerThrottlingEnabled = shouldThrottle;
> -
> -    if (previousInterval != timerAlignmentInterval())
> -        didChangeTimerAlignmentInterval();
> +    didChangeTimerAlignmentInterval();

Why this change?

[Chris Dumez]

Comment on attachment 254961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254961&action=review

>> Source/WebCore/dom/Document.cpp:2764
>> +    didChangeTimerAlignmentInterval();
> 
> Why this change?

Now timerAlignmentInterval() takes an argument that is timer-specific so we can no longer call it here to determine if we should call didChangeTimerAlignmentInterval().

We need to call didChangeTimerAlignmentInterval() to notify all timers that their alignment may have changed. It is better to call this one too often rather than not enough as otherwise we may fail to update the interval of some timers.
If the document-level throttling state has changed, some timers in the Document (the ones that have reached the max nesting level) need to be updated so we need to call this function.

[Chris Dumez]

Comment on attachment 254961 [details]
Patch

Clearing flags on attachment: 254961

Committed r185602: <http://trac.webkit.org/changeset/185602>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.