Summary: | AX: Add ARIA 1.1 "cell" and "table" roles | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||||||||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, bfulgham, buildbot, cfleizach, clopez, commit-queue, dmazzoni, jdiggs, mario, n_wang, rniwa, samuel_white, webkit-bug-importer | ||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||
Bug Depends on: | 146887 | ||||||||||||||||||||||
Bug Blocks: | 136415 | ||||||||||||||||||||||
Attachments: |
|
Created attachment 256581 [details]
patch
Comment on attachment 256581 [details] patch Attachment 256581 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6466871326932992 New failing tests: accessibility/roles-exposed.html accessibility/aria-table-with-presentational-elements.html Created attachment 256583 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 256581 [details] patch Attachment 256581 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5021898299670528 New failing tests: accessibility/roles-exposed.html accessibility/aria-table-with-presentational-elements.html Created attachment 256586 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 256598 [details]
patch to fix mavericks' test expectation
Comment on attachment 256598 [details]
patch to fix mavericks' test expectation
we only need the patch for just the new things
Created attachment 256600 [details]
patch to fix computedRoleString test
Comment on attachment 256600 [details] patch to fix computedRoleString test Attachment 256600 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5889576182743040 New failing tests: accessibility/aria-table-with-presentational-elements.html Created attachment 256602 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 256600 [details] patch to fix computedRoleString test Attachment 256600 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4689070546485248 New failing tests: accessibility/aria-table-with-presentational-elements.html Created attachment 256603 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 256606 [details]
patch that fixed test expectation
Comment on attachment 256606 [details] patch that fixed test expectation Clearing flags on attachment: 256606 Committed r186692: <http://trac.webkit.org/changeset/186692> All reviewed patches have been landed. Closing bug. These tests fail on Windows. Can you please add a skip for them and file a bug to implement the missing features? (In reply to comment #17) > These tests fail on Windows. Can you please add a skip for them and file a > bug to implement the missing features? They fail also for GTK. (In reply to comment #17) > These tests fail on Windows. Can you please add a skip for them and file a > bug to implement the missing features? I'll be working on adding new expectations for not working platforms. Created attachment 256740 [details]
patch with windows test expectation
|
> The new roles can be found here: > https://rawgit.com/w3c/aria/master/aria/aria.html#cell > https://rawgit.com/w3c/aria/master/aria/aria.html#table I don't think WebKit has special behavior for the interactive portion of the grid and gridcell roles, so these can probably be aliases for now. computedRoleString should be updated to use the static variants, too.