Bug 145983

Summary: Web Inspector: Consider making read-only style rules have a darker background
Product: WebKit Reporter: Chris Chiera <chris>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.10   
Attachments:
Description Flags
Patch
none
[Image] After the patch applied none

Chris Chiera
Reported 2015-06-15 12:52:58 PDT
On iOS 8.1 Mac 10.11. In Chrome, rules that are not editable such as "User Agent Stylesheet" have a darkened background so at quick glance you know the rules aren't editable and look distinct from the surrounding rules that are editable. In Safari the rules look identical including the background color with the exception of a little lock icon in the right. While I think the lock icon follows Apple's design aesthetic and can be there, but the background of the uneducable rules should be the Safari header gray rather than White like Chrome to make it instantly clear it's not editable.
Attachments
Patch (2.11 KB, patch)
2015-06-20 18:14 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Image] After the patch applied (76.18 KB, image/png)
2015-06-20 18:20 PDT, Nikita Vasilyev 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-15 12:53:31 PDT
<rdar://problem/21388092>
Nikita Vasilyev
Comment 2 2015-06-20 18:14:17 PDT
Created attachment 255304 [details] Patch I think this would be a positive change.
Nikita Vasilyev
Comment 3 2015-06-20 18:20:55 PDT
Created attachment 255305 [details] [Image] After the patch applied
WebKit Commit Bot
Comment 4 2015-06-22 10:54:30 PDT
Comment on attachment 255304 [details] Patch Clearing flags on attachment: 255304 Committed r185836: <http://trac.webkit.org/changeset/185836>
WebKit Commit Bot
Comment 5 2015-06-22 10:54:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.