Bug 145977

Summary: [WK2] BrowsingContextController.loadData API is leaking Navigation objects
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, commit-queue, darin, kling, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145948
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-06-15 09:53:19 PDT
BrowsingContextController.loadData API is leaking Navigation objects. The issue seems to be that WebPageProxy::loadData() creates a Navigation object but does not pass the navigationID to the WebProcess when sending the essages::WebPage::LoadData IPC. As a result, the WebProcess is using 0 as navigationID and we end up creating a new Navigation object later on for the same navigation. Radar: <rdar://problem/21305706>
Attachments
Patch (5.91 KB, patch)
2015-06-15 11:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-06-15 11:25:17 PDT
Created attachment 254885 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-15 12:29:45 PDT
Comment on attachment 254885 [details] Patch Clearing flags on attachment: 254885 Committed r185563: <http://trac.webkit.org/changeset/185563>
WebKit Commit Bot
Comment 3 2015-06-15 12:29:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.