Bug 145938 – Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

Content on the 'developer.apple.com' site recently moved. The LWP::Simple methods being used did not properly respect the redirect status, and started failing.

This patch corrects this problem.

[Brent Fulgham]

Created attachment 254819 [details]
Patch

[Brent Fulgham]

Created attachment 254823 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 254819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254819&action=review

> Tools/ChangeLog:3
> +        Correct update-webkit-dependency to handle redirects

I don't see any redirect when trying with curl. Maybe something else is wrong.

> Tools/Scripts/update-webkit-dependency:90
> +my $content_type = $response->header('Content-Type');
> +my $document_length = $response->header('Content-Length');
> +my $modified_time = $response->header('Last-Modified'); 
> +my $expires;
> +my $server = $response->header('Server'); 

Are these needed?

> Tools/Scripts/update-webkit-dependency:110
> +        if ($result == 300) {

300 is Multiple Choice.

Brent says that this is debugging code that needs to be removed.

[Alexey Proskuryakov]

Comment on attachment 254823 [details]
Patch

Carrying over r+ from the previous patch.

[Brent Fulgham]

Committed r185522: <http://trac.webkit.org/changeset/185522>