Bug 145938

Summary: Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Description Brent Fulgham 2015-06-12 14:24:19 PDT
Content on the 'developer.apple.com' site recently moved. The LWP::Simple methods being used did not properly respect the redirect status, and started failing.

This patch corrects this problem.
Comment 1 Brent Fulgham 2015-06-12 14:28:18 PDT
Created attachment 254819 [details]
Patch
Comment 2 Brent Fulgham 2015-06-12 14:50:40 PDT
Created attachment 254823 [details]
Patch
Comment 3 Alexey Proskuryakov 2015-06-12 14:57:16 PDT
Comment on attachment 254819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254819&action=review

> Tools/ChangeLog:3
> +        Correct update-webkit-dependency to handle redirects

I don't see any redirect when trying with curl. Maybe something else is wrong.

> Tools/Scripts/update-webkit-dependency:90
> +my $content_type = $response->header('Content-Type');
> +my $document_length = $response->header('Content-Length');
> +my $modified_time = $response->header('Last-Modified'); 
> +my $expires;
> +my $server = $response->header('Server'); 

Are these needed?

> Tools/Scripts/update-webkit-dependency:110
> +        if ($result == 300) {

300 is Multiple Choice.

Brent says that this is debugging code that needs to be removed.
Comment 4 Alexey Proskuryakov 2015-06-12 14:57:42 PDT
Comment on attachment 254823 [details]
Patch

Carrying over r+ from the previous patch.
Comment 5 Brent Fulgham 2015-06-12 15:09:18 PDT
Committed r185522: <http://trac.webkit.org/changeset/185522>