Bug 145925

Summary: Fix unused private field warning in PageBanner.h
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145121    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-06-12 05:09:39 PDT
In file included from ../../Source/WebKit2/WebProcess/WebPage/PageBanner.cpp:27: ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:86:10: warning: private field 'm_type' is not used [-Wunused-private-field] Type m_type; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:88:14: warning: private field 'm_webPage' is not used [-Wunused-private-field] WebPage* m_webPage; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:90:10: warning: private field 'm_mouseDownInBanner' is not used [-Wunused-private-field] bool m_mouseDownInBanner; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:91:10: warning: private field 'm_isHidden' is not used [-Wunused-private-field] bool m_isHidden; ^ 4 warnings generated.
Attachments
Patch (2.65 KB, patch)
2015-06-12 05:15 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (3.15 KB, patch)
2015-06-15 02:41 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-06-12 05:15:07 PDT
Created attachment 254795 [details] Patch
Darin Adler
Comment 2 2015-06-12 09:41:52 PDT
Comment on attachment 254795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review > Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 > + Type m_type; > + WebPage* m_webPage; Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] Need to fix this before landing.
Darin Adler
Comment 3 2015-06-12 09:42:36 PDT
Comment on attachment 254795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review >> Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 >> + WebPage* m_webPage; > > Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] > > Need to fix this before landing. Best way to fix it is probably to initialize m_type, m_webPage, m_mouseDownInBanner, and m_isHidden in the header rather than in the constructor.
Csaba Osztrogonác
Comment 4 2015-06-15 02:41:40 PDT
Created attachment 254867 [details] Patch Good point, I fixed it.
WebKit Commit Bot
Comment 5 2015-06-15 04:21:12 PDT
Comment on attachment 254867 [details] Patch Clearing flags on attachment: 254867 Committed r185549: <http://trac.webkit.org/changeset/185549>
WebKit Commit Bot
Comment 6 2015-06-15 04:21:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.