| Summary: | Fix unused private field warning in PageBanner.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 145121 | ||||||||
| Attachments: |
|
||||||||
Created attachment 254795 [details]
Patch
Comment on attachment 254795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review > Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 > + Type m_type; > + WebPage* m_webPage; Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] Need to fix this before landing. Comment on attachment 254795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254795&action=review >> Source/WebKit2/WebProcess/WebPage/PageBanner.h:90 >> + WebPage* m_webPage; > > Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:45:7: error: field 'm_type' will be initialized after field 'm_client' [-Werror,-Wreorder] > > Need to fix this before landing. Best way to fix it is probably to initialize m_type, m_webPage, m_mouseDownInBanner, and m_isHidden in the header rather than in the constructor. Created attachment 254867 [details]
Patch
Good point, I fixed it.
Comment on attachment 254867 [details] Patch Clearing flags on attachment: 254867 Committed r185549: <http://trac.webkit.org/changeset/185549> All reviewed patches have been landed. Closing bug. |
In file included from ../../Source/WebKit2/WebProcess/WebPage/PageBanner.cpp:27: ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:86:10: warning: private field 'm_type' is not used [-Wunused-private-field] Type m_type; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:88:14: warning: private field 'm_webPage' is not used [-Wunused-private-field] WebPage* m_webPage; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:90:10: warning: private field 'm_mouseDownInBanner' is not used [-Wunused-private-field] bool m_mouseDownInBanner; ^ ../../Source/WebKit2/WebProcess/WebPage/PageBanner.h:91:10: warning: private field 'm_isHidden' is not used [-Wunused-private-field] bool m_isHidden; ^ 4 warnings generated.