| Summary: | Fix overloaded virtual function warning in ScrollbarThemeGtk.h | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, clopez, commit-queue, ossy, zan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 145121 | ||||||
| Attachments: |
|
||||||
Created attachment 256580 [details]
Patch
Now the thumbRect of the baseclass isn't used (it would be compile error), but the easiest way to fix this warning is to unhide it for the compiler with an explicit using.
Comment on attachment 256580 [details] Patch Clearing flags on attachment: 256580 Committed r186680: <http://trac.webkit.org/changeset/186680> All reviewed patches have been landed. Closing bug. |
In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:48:13: warning: 'WebCore::ScrollbarThemeGtk::thumbRect' hides overloaded virtual function [-Woverloaded-virtual] IntRect thumbRect(ScrollbarThemeClient*, const IntRect& unconstrainedTrackRect); ^ ../../Source/WebCore/platform/ScrollbarThemeComposite.h:58:21: note: hidden overloaded virtual function 'WebCore::ScrollbarThemeComposite::thumbRect' declared here: different number of parameters (1 vs 2) virtual IntRect thumbRect(ScrollbarThemeClient*); ^ 1 warning generated.