Bug 145901

Summary: [WK2] Add allowsPictureInPictureMediaPlayback
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, eric.carlson, jeremyj-wk, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145825    
Attachments:
Description Flags
Patch andersca: review+

Jon Lee
Reported 2015-06-11 16:43:02 PDT
Add allowsPictureInPictureMediaPlayback
Attachments
Patch (5.86 KB, patch)
2015-06-11 16:57 PDT, Jon Lee 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-11 16:43:24 PDT
<rdar://problem/21349851>
Jon Lee
Comment 2 2015-06-11 16:57:35 PDT
Created attachment 254769 [details] Patch
Anders Carlsson
Comment 3 2015-06-12 10:41:47 PDT
Comment on attachment 254769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review This needs to go through internal API review (unless it already has). > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 > -#if PLATFORM(IOS) > -- (BOOL)_allowsAlternateFullscreen > -{ > - return _allowsAlternateFullscreen; > -} > - > -- (void)_setAllowsAlternateFullscreen:(BOOL)allowed > -{ > - _allowsAlternateFullscreen = allowed; > -} > -#endif > - We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari.
Jon Lee
Comment 4 2015-06-12 15:19:05 PDT
Comment on attachment 254769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 >> - > > We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari. As far as I can tell, no client calls this SPI, including iOS Safari. So I plan on removing it.
Jon Lee
Comment 5 2015-06-12 15:19:30 PDT
(In reply to comment #3) > Comment on attachment 254769 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254769&action=review > > This needs to go through internal API review (unless it already has). It already has. No objections :)
Jon Lee
Comment 6 2015-06-15 11:07:41 PDT
Committed r185556: <http://trac.webkit.org/changeset/185556>
Note You need to log in before you can comment on or make changes to this bug.