| Summary: | [WK2] Add allowsPictureInPictureMediaPlayback | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
| Component: | Media | Assignee: | Jon Lee <jonlee> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, eric.carlson, jeremyj-wk, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 145825 | ||||||
| Attachments: |
|
||||||
|
Description
Jon Lee
2015-06-11 16:43:02 PDT
Created attachment 254769 [details]
Patch
Comment on attachment 254769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review This needs to go through internal API review (unless it already has). > Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 > -#if PLATFORM(IOS) > -- (BOOL)_allowsAlternateFullscreen > -{ > - return _allowsAlternateFullscreen; > -} > - > -- (void)_setAllowsAlternateFullscreen:(BOOL)allowed > -{ > - _allowsAlternateFullscreen = allowed; > -} > -#endif > - We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari. Comment on attachment 254769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254769&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-327 >> - > > We probably need to keep these for now (and just have them call the SPI methods) so we won't break iOS Safari. As far as I can tell, no client calls this SPI, including iOS Safari. So I plan on removing it. (In reply to comment #3) > Comment on attachment 254769 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254769&action=review > > This needs to go through internal API review (unless it already has). It already has. No objections :) Committed r185556: <http://trac.webkit.org/changeset/185556> |