Bug 145898

Summary: Web Inspector: CRASH trying to inspect text that was removed/replaced
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-06-11 14:25:56 PDT
* SUMMARY
Trying to inspect an element via the Context Menu but that element is removed causes a crash.

* TEST
<body>
<script>
var i = 0;
var box = document.body.appendChild(document.createElement("p"));
var span = box.appendChild(document.createElement("span"));
setInterval(function() { span.textContent = (i++) + " seconds"; }, 500);
</script>

* STEPS TO REPRODUCE
1. Load test
2. Right click the "N seconds" text and wait a second for it to change
3. Select "Inspect Element"
  => CRASH

* NOTES
- We assume the focus node is in the document, but it may not be by the time Inspect Element is triggered.
Comment 1 Joseph Pecoraro 2015-06-11 14:26:25 PDT
<rdar://problem/18921081>
Comment 2 Joseph Pecoraro 2015-06-11 14:28:46 PDT
Created attachment 254758 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2015-06-12 09:49:34 PDT
Comment on attachment 254758 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 254758

Committed r185507: <http://trac.webkit.org/changeset/185507>
Comment 4 WebKit Commit Bot 2015-06-12 09:49:39 PDT
All reviewed patches have been landed.  Closing bug.