Bug 145875

Summary: [GTK] Add API to be notified about editor state changes
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mcatanzaro, mcrha, mrobinson, tpopela, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147196
Bug Depends on:    
Bug Blocks: 146781    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2015-06-11 00:44:09 PDT
This is useful to update the UI according to the editor state for editable web views. For now we could just expose the typing attributes, so that the toggle buttons for Bold, Italic, etc. can be updated when needed. I think this will make evolution composer a lot simpler (it still needs selection-changed in the web process for other things, though).
Attachments
Patch (47.51 KB, patch)
2015-06-11 01:04 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-06-11 01:04:52 PDT
Created attachment 254712 [details] Patch
Carlos Garcia Campos
Comment 2 2015-07-07 03:11:53 PDT
ping reviewers
Gustavo Noronha (kov)
Comment 3 2015-07-20 10:54:53 PDT
Comment on attachment 254712 [details] Patch LGTM =)
Carlos Garcia Campos
Comment 4 2015-07-20 23:07:46 PDT
Committed r187100: <http://trac.webkit.org/changeset/187100>
Michael Catanzaro
Comment 5 2015-07-22 12:31:57 PDT
This caused bug #147196
Note You need to log in before you can comment on or make changes to this bug.