Bug 145855

Summary:

Overriding the overlay scrollbar style on WKView doesn't take effect immediately

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Beth Dakin 2015-06-10 14:22:26 PDT

If the scrollbar style is changed dynamically after the WKView is loaded, then the new style won't actually change until rubber-banding.

rdar://problem/20948706

Comment 1 Beth Dakin 2015-06-10 14:42:59 PDT

Created attachment 254677 [details]
Patch

Comment 2 Simon Fraser (smfr) 2015-06-10 14:44:19 PDT

Comment on attachment 254677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254677&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020
> +    if (!painter)
> +        return;
> +    [painter setNeedsDisplay:YES];

It would be OK removing the null check, since messaging nil is OK.

Comment 3 Beth Dakin 2015-06-10 14:54:57 PDT

(In reply to comment #2)
> Comment on attachment 254677 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254677&action=review
> 
> > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:1020
> > +    if (!painter)
> > +        return;
> > +    [painter setNeedsDisplay:YES];
> 
> It would be OK removing the null check, since messaging nil is OK.

Good point. Removed!

Thanks, Simon! http://trac.webkit.org/changeset/185431