Bug 145852

Summary: Disable UIWindow for fullscreen video for selected clients.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing.
commit-queue: commit-queue-
Patch for landing. none

Jeremy Jones
Reported 2015-06-10 13:09:32 PDT
Disable UIWindow for fullscreen video for selected clients.
Attachments
Patch (9.79 KB, patch)
2015-06-10 13:20 PDT, Jeremy Jones 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for landing. (9.87 KB, patch)
2015-06-18 15:27 PDT, Jeremy Jones 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (8.50 KB, patch)
2015-06-18 19:27 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2015-06-10 13:20:45 PDT
Created attachment 254671 [details] Patch
Jeremy Jones
Comment 2 2015-06-10 13:21:44 PDT
rdar://problem/21325340
Jeremy Jones
Comment 3 2015-06-18 15:26:16 PDT
Use -[UIWindow _isHostedInAnotherProcess] to detect being in a view service and remove growing list of bundle identifier checks.
Jeremy Jones
Comment 4 2015-06-18 15:27:27 PDT
Created attachment 255140 [details] Patch for landing.
WebKit Commit Bot
Comment 5 2015-06-18 17:14:06 PDT
Comment on attachment 255140 [details] Patch for landing. Rejecting attachment 255140 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 255140, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: d83800c6e218db169d6b5a03f64a7adfd1d r185725 = 639e26bcc11ef8ee30f050f0f4a482859367e483 r185726 = 1a759b8d8a124ed1dc22df1a3cd91e9582578ec2 r185727 = 92313237a681dcd39ad022f0f1b32e6db1562088 r185728 = ea361c1fb59d6470e7b3e6da359ce3a4b5db61a8 r185729 = 1cb8e15d3ff6326e79ac5ba13b1e0f265a2af584 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/5674861896663040
Jeremy Jones
Comment 6 2015-06-18 19:27:21 PDT
Created attachment 255164 [details] Patch for landing.
WebKit Commit Bot
Comment 7 2015-06-18 20:46:49 PDT
Comment on attachment 255164 [details] Patch for landing. Clearing flags on attachment: 255164 Committed r185733: <http://trac.webkit.org/changeset/185733>
Darin Adler
Comment 8 2015-06-19 10:14:24 PDT
Comment on attachment 255164 [details] Patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=255164&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:881 > +@interface UIWindow () > +-(BOOL)_isHostedInAnotherProcess; > +@end I think we have a new best practice for this sort of thing that involves a header file with a name that ends in “SPI.h”.
Jeremy Jones
Comment 9 2015-06-19 11:21:22 PDT
(In reply to comment #8) > Comment on attachment 255164 [details] > Patch for landing. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255164&action=review > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:881 > > +@interface UIWindow () > > +-(BOOL)_isHostedInAnotherProcess; > > +@end > > I think we have a new best practice for this sort of thing that involves a > header file with a name that ends in “SPI.h”. Noted. This will go away when we complete rdar://problem/19708648 In the mean time I've filed https://bugs.webkit.org/show_bug.cgi?id=146151 to cover this request.
Note You need to log in before you can comment on or make changes to this bug.