Bug 145847

Summary: Add barebones implementation of media session invocation algorithm
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch none

Description Matt Rajca 2015-06-10 11:32:32 PDT 
Add a barebones implementation of the media session invocation algorithm that at least moves the media session to an ACTIVE state so MediaPlayPause events can function.
Comment 1 Radar WebKit Bug Importer 2015-06-10 11:33:24 PDT 
<rdar://problem/21324294>
Comment 2 Matt Rajca 2015-06-10 11:38:59 PDT 
Created attachment 254665 [details]
Patch
Comment 3 Matt Rajca 2015-06-11 15:33:46 PDT 
Created attachment 254762 [details]
Patch
Comment 4 Darin Adler 2015-06-12 09:53:55 PDT 
Comment on attachment 254762 [details]
Patch

This is fine, but I am concerned about us adding this code without tests. When will we be adding the tests?
Comment 5 Matt Rajca 2015-06-12 09:59:56 PDT 
(In reply to comment #4)
> Comment on attachment 254762 [details]
> Patch
> 
> This is fine, but I am concerned about us adding this code without tests.
> When will we be adding the tests?

Once I add basic support for the other two media event types (next track and previous track), I will work on tests.
Comment 6 WebKit Commit Bot 2015-06-12 10:54:11 PDT 
Comment on attachment 254762 [details]
Patch

Clearing flags on attachment: 254762

Committed r185514: <http://trac.webkit.org/changeset/185514>
Comment 7 WebKit Commit Bot 2015-06-12 10:54:16 PDT 
All reviewed patches have been landed.  Closing bug.