Summary: | Add barebones implementation of media session invocation algorithm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Rajca <mrajca> | ||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, conrad_shultz, eric.carlson, jer.noble, mrajca, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 145411 | ||||||||
Attachments: |
|
Description
Matt Rajca
2015-06-10 11:32:32 PDT
Created attachment 254665 [details]
Patch
Created attachment 254762 [details]
Patch
Comment on attachment 254762 [details]
Patch
This is fine, but I am concerned about us adding this code without tests. When will we be adding the tests?
(In reply to comment #4) > Comment on attachment 254762 [details] > Patch > > This is fine, but I am concerned about us adding this code without tests. > When will we be adding the tests? Once I add basic support for the other two media event types (next track and previous track), I will work on tests. Comment on attachment 254762 [details] Patch Clearing flags on attachment: 254762 Committed r185514: <http://trac.webkit.org/changeset/185514> All reviewed patches have been landed. Closing bug. |