Bug 145840

Summary:

[GTK] Move KeyBindingTranslator from platform to WebKit2 layer

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, pnormand, rniwa, svillar, zan

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none

Description Carlos Garcia Campos 2015-06-10 06:42:53 PDT

It's currently used only by WebKit2 in the UI process and it's another file built twice because of the GTK2 plugin process.

Comment 1 Carlos Garcia Campos 2015-06-10 06:51:56 PDT

Created attachment 254648 [details]
Patch

Comment 2 WebKit Commit Bot 2015-06-10 06:53:23 PDT

Attachment 254648 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:124:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:126:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:128:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:134:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:136:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:140:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:142:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 10 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Build Bot 2015-06-10 08:01:54 PDT

Comment on attachment 254648 [details]
Patch

Attachment 254648 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4546634922852352

New failing tests:
webaudio/audiocontext-state-interrupted.html

Comment 4 Build Bot 2015-06-10 08:01:57 PDT

Created attachment 254654 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 5 Carlos Garcia Campos 2015-06-10 08:18:33 PDT

Committed r185416: <http://trac.webkit.org/changeset/185416>