Bug 145840

Summary: [GTK] Move KeyBindingTranslator from platform to WebKit2 layer
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, pnormand, rniwa, svillar, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mrobinson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks none

Carlos Garcia Campos
Reported 2015-06-10 06:42:53 PDT
It's currently used only by WebKit2 in the UI process and it's another file built twice because of the GTK2 plugin process.
Attachments
Patch (28.32 KB, patch)
2015-06-10 06:51 PDT, Carlos Garcia Campos 		mrobinson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-mavericks (595.93 KB, application/zip)
2015-06-10 08:01 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-06-10 06:51:56 PDT
Created attachment 254648 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-10 06:53:23 PDT
Attachment 254648 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 10 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2015-06-10 08:01:54 PDT
Comment on attachment 254648 [details] Patch Attachment 254648 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4546634922852352 New failing tests: webaudio/audiocontext-state-interrupted.html
Build Bot
Comment 4 2015-06-10 08:01:57 PDT
Created attachment 254654 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Carlos Garcia Campos
Comment 5 2015-06-10 08:18:33 PDT
Committed r185416: <http://trac.webkit.org/changeset/185416>
Note You need to log in before you can comment on or make changes to this bug.